Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 610893003: Remove #ifdefs around ShowLinkDisambiguationPopup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: callback_forward Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index fcb9e9bb543e19b5e792c636667beb8945fc445a..0c00c580d2562a82d7e6c5a42b9cded2b7ed0c51 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -331,14 +331,16 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
virtual gfx::GLSurfaceHandle GetCompositingSurface() = 0;
+ // Called by the RenderFrameHost when it recieves an IPC response to a
Avi (use Gerrit) 2014/09/29 14:32:10 receives
tapted 2014/09/29 23:06:58 Done.
+ // TextSurroundingSelectionRequest.
virtual void OnTextSurroundingSelectionResponse(const base::string16& content,
size_t start_offset,
- size_t end_offset) {};
+ size_t end_offset);
-#if defined(OS_ANDROID) || defined(TOOLKIT_VIEWS) || defined(USE_AURA)
+ // Called by the RenderWidgetHost when an ambiguous gesture is detected to
+ // show the disambiguation popup bubble.
virtual void ShowDisambiguationPopup(const gfx::Rect& rect_pixels,
- const SkBitmap& zoomed_bitmap) = 0;
-#endif
+ const SkBitmap& zoomed_bitmap);
#if defined(OS_ANDROID)
// Instructs the view to not drop the surface even when the view is hidden.

Powered by Google App Engine
This is Rietveld 408576698