Remove #ifdefs around ShowLinkDisambiguationPopup

Remove #ifdefs around ShowLinkDisambiguationPopup

Current efforts are aimed at harmonizing our UI code. #ifdefs work
against this and have a lot of downsides besides.

This is a follow-up to http://crrev.com/351683002 -- a long-running CL
which added ShowLinkDisambiguationPopup to Aura -- and
http://crrev.com/596373002 which fixed some build problems with that.
However, toolkit_views=1 use_aura=0 which is in use on Mac still has
problems.

This CL adds default method definitions to WebContentsViewDelegate and
RenderWidgetHostViewBase. Essentially moving a NOTIMPLEMENTED() guarded
by #ifdefs into a base class method, and removing some unnecessary
boilerplate.

BUG=385249, 399191
Committed: https://crrev.com/7e0b5922f9c88d1a733bf95c084c9f1646a8777e
Cr-Commit-Position: refs/heads/master@{#297360}

[tapted, 2014-09-29 06:17:31]

Patchset #2 (id:20001) has been deleted

[tapted, 2014-09-29 07:00:31]

tapted@chromium.org changed reviewers:
+ avi@chromium.org

[tapted, 2014-09-29 07:00:31]

Hi avi, please take a look

cc dnicoara/luken FYI (I've run some linux_ecs_ozone jobs - all looks good).

Thanks!

[Avi (use Gerrit), 2014-09-29 14:32:10]

lgtm

https://codereview.chromium.org/610893003/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

https://codereview.chromium.org/610893003/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_base.h:334: // Called by
the RenderFrameHost when it recieves an IPC response to a
receives

[tapted, 2014-09-29 23:06:58]

Thanks!

https://codereview.chromium.org/610893003/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

https://codereview.chromium.org/610893003/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_base.h:334: // Called by
the RenderFrameHost when it recieves an IPC response to a
On 2014/09/29 14:32:10, Avi wrote:
> receives

Done.

[tapted, 2014-09-29 23:07:12]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-09-29 23:09:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/610893003/60001

[commit-bot: I haz the power, 2014-09-30 01:46:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 01:46:49]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tapted, 2014-09-30 02:47:34]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-09-30 02:52:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/610893003/60001

[commit-bot: I haz the power, 2014-09-30 04:19:13]

Committed patchset #3 (id:60001) as f07af7b5a951c9ad706cc3ea9228aa9ecbd418ab

[commit-bot: I haz the power, 2014-09-30 04:20:10]

Patchset 3 (id:??) landed as
https://crrev.com/7e0b5922f9c88d1a733bf95c084c9f1646a8777e
Cr-Commit-Position: refs/heads/master@{#297360}

[luken, 2014-09-30 17:49:31]

On 2014/09/30 04:20:10, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/7e0b5922f9c88d1a733bf95c084c9f1646a8777e
> Cr-Commit-Position: refs/heads/master@{#297360}

Thanks for fixing this!