Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 610863004: Start implementing checked mode compile time errors in analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 35d6613b154389d847b91fcf68d146a702f284d7..b88381e0c4fb5d9295eecfa006531e6aef9a5efd 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1441,9 +1441,7 @@ class AnalysisCommandOutputImpl extends CommandOutputImpl {
parseAnalyzerOutput(errors, warnings);
// Handle errors / missing errors
- if (testCase.hasCompileError) {
- // Don't use [TestCase.expectCompileError] since the analyzer does not
- // (currently) report checked-mode only compile time errors.
+ if (testCase.expectCompileError) {
if (errors.length > 0) {
return Expectation.PASS;
}
« tests/language/language_analyzer2.status ('K') | « tests/language/language_analyzer2.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698