Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/IceRegAlloc.cpp

Issue 610813002: Subzero: Rewrite the pass timing infrastructure. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Bug fixes and performance improvements Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceOperand.cpp ('K') | « src/IceOperand.cpp ('k') | src/IceTargetLowering.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceRegAlloc.cpp
diff --git a/src/IceRegAlloc.cpp b/src/IceRegAlloc.cpp
index 36ada129b3d6611fedc44e55ad01ee1cb54e16ca..2b57292da987d245fd66ef2a2bdd64e99a02b321 100644
--- a/src/IceRegAlloc.cpp
+++ b/src/IceRegAlloc.cpp
@@ -64,12 +64,14 @@ void dumpDisableOverlap(const Cfg *Func, const Variable *Var,
// preparation. Results are assigned to Variable::RegNum for each
// Variable.
void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
+ TimerMarker T("scan", Func->getContext());
assert(RegMaskFull.any()); // Sanity check
Unhandled.clear();
Handled.clear();
Inactive.clear();
Active.clear();
Ostream &Str = Func->getContext()->getStrDump();
+ bool Verbose = Func->getContext()->isVerbose(IceV_LinearScan);
Func->resetCurrentNode();
VariablesMetadata *VMetadata = Func->getVMetadata();
@@ -81,20 +83,24 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
// a result, it may be useful to design a better data structure for
// storing Func->getVariables().
const VarList &Vars = Func->getVariables();
- for (VarList::const_iterator I = Vars.begin(), E = Vars.end(); I != E; ++I) {
- Variable *Var = *I;
- // Explicitly don't consider zero-weight variables, which are
- // meant to be spill slots.
- if (Var->getWeight() == RegWeight::Zero)
- continue;
- // Don't bother if the variable has a null live range, which means
- // it was never referenced.
- if (Var->getLiveRange().isEmpty())
- continue;
- Unhandled.insert(LiveRangeWrapper(Var));
- if (Var->hasReg()) {
- Var->setRegNumTmp(Var->getRegNum());
- Var->setLiveRangeInfiniteWeight();
+ {
+ TimerMarker T("initUnhandled", Func->getContext());
+ for (VarList::const_iterator I = Vars.begin(), E = Vars.end(); I != E;
+ ++I) {
+ Variable *Var = *I;
+ // Explicitly don't consider zero-weight variables, which are
+ // meant to be spill slots.
+ if (Var->getWeight() == RegWeight::Zero)
+ continue;
+ // Don't bother if the variable has a null live range, which means
+ // it was never referenced.
+ if (Var->getLiveRange().isEmpty())
+ continue;
+ Unhandled.insert(LiveRangeWrapper(Var));
+ if (Var->hasReg()) {
+ Var->setRegNumTmp(Var->getRegNum());
+ Var->setLiveRangeInfiniteWeight();
+ }
}
}
@@ -112,7 +118,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
while (!Unhandled.empty()) {
LiveRangeWrapper Cur = *Unhandled.begin();
Unhandled.erase(Unhandled.begin());
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "\nConsidering ";
Cur.dump(Func);
Str << "\n";
@@ -130,7 +136,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
int32_t RegNum = Cur.Var->getRegNum();
// RegNumTmp should have already been set above.
assert(Cur.Var->getRegNumTmp() == RegNum);
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Precoloring ";
Cur.dump(Func);
Str << "\n";
@@ -150,7 +156,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
bool Moved = false;
if (Item.endsBefore(Cur)) {
// Move Item from Active to Handled list.
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Expiring ";
Item.dump(Func);
Str << "\n";
@@ -160,7 +166,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
Moved = true;
} else if (!Item.overlapsStart(Cur)) {
// Move Item from Active to Inactive list.
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Inactivating ";
Item.dump(Func);
Str << "\n";
@@ -186,7 +192,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
LiveRangeWrapper Item = *I;
if (Item.endsBefore(Cur)) {
// Move Item from Inactive to Handled list.
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Expiring ";
Item.dump(Func);
Str << "\n";
@@ -195,7 +201,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
Handled.push_back(Item);
} else if (Item.overlapsStart(Cur)) {
// Move Item from Inactive to Active list.
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Reactivating ";
Item.dump(Func);
Str << "\n";
@@ -261,7 +267,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
}
}
}
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
if (Prefer) {
Str << "Initial Prefer=" << *Prefer << " R=" << PreferReg
<< " LIVE=" << Prefer->getLiveRange() << " Overlap=" << AllowOverlap
@@ -275,8 +281,8 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
E = Inactive.end();
I != E; ++I) {
LiveRangeWrapper Item = *I;
- if (Item.overlaps(Cur)) {
- int32_t RegNum = Item.Var->getRegNumTmp();
+ int32_t RegNum = Item.Var->getRegNumTmp();
+ if (Free[RegNum] && Item.overlaps(Cur)) {
Jim Stichnoth 2014/09/28 14:26:39 Performance optimization to check Free[] before th
// Don't assert(Free[RegNum]) because in theory (though
// probably never in practice) there could be two inactive
// variables that were allowed marked with
@@ -331,7 +337,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
}
// Print info about physical register availability.
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
for (SizeT i = 0; i < RegMask.size(); ++i) {
if (RegMask[i]) {
Str << Func->getTarget()->getRegName(i, IceType_i32)
@@ -346,7 +352,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
// First choice: a preferred register that is either free or is
// allowed to overlap with its linked variable.
Cur.Var->setRegNumTmp(PreferReg);
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Preferring ";
Cur.dump(Func);
Str << "\n";
@@ -360,7 +366,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
// picking the lowest-numbered available register?
int32_t RegNum = Free.find_first();
Cur.Var->setRegNumTmp(RegNum);
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Allocating ";
Cur.dump(Func);
Str << "\n";
@@ -434,7 +440,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
++Next;
LiveRangeWrapper Item = *I;
if (Item.Var->getRegNumTmp() == MinWeightIndex) {
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Evicting ";
Item.dump(Func);
Str << "\n";
@@ -463,7 +469,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
// instructions.
if (Item.Var->getRegNumTmp() == MinWeightIndex &&
Item.overlaps(Cur)) {
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Evicting ";
Item.dump(Func);
Str << "\n";
@@ -478,7 +484,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
assert(RegUses[MinWeightIndex] >= 0);
++RegUses[MinWeightIndex];
Active.push_back(Cur);
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
Str << "Allocating ";
Cur.dump(Func);
Str << "\n";
@@ -509,7 +515,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {
I != E; ++I) {
LiveRangeWrapper Item = *I;
int32_t RegNum = Item.Var->getRegNumTmp();
- if (Func->getContext()->isVerbose(IceV_LinearScan)) {
+ if (Verbose) {
if (!Item.Var->hasRegTmp()) {
Str << "Not assigning ";
Item.Var->dump(Func);
« src/IceOperand.cpp ('K') | « src/IceOperand.cpp ('k') | src/IceTargetLowering.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698