Subzero: Rewrite the pass timing infrastructure.

src/IceOperand.cpp

 //===- subzero/src/IceOperand.cpp - High-level operand implementation -----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the Operand class and its target-independent
@@ skipping 104 matching lines @@
     if (I2->second <= I1->first) {
       ++I2;
       continue;
     }
     return true;
   }
   return false;
 }
 
 bool LiveRange::overlaps(InstNumberT OtherBegin) const {
+  for (RangeType::const_iterator I = Range.begin(), E = Range.end(); I != E;
+       ++I) {
+    if (OtherBegin >= I->second)

[jvoung (off chromium), 2014/09/30 23:38:44]

So the issue was that the ranges are sorted the other way?

OtherBegin might be >= I->second for some of the earlier ranges, even though it
overlaps later?

[Jim Stichnoth, 2014/09/30 23:49:16]

No, the segments of the live range must be sorted, though that is only enforced
if the USE_SET define is enabled.  E.g., LiveRange::overlaps() relies on
iterating in increasing sorted order.

The only thing that makes sense to me is that I implemented something, validated
it against the original implementation, cleaned out the validation code, then
"optimized" the new implementation without re-validating. :(

+      return false;
+    if (I->first <= OtherBegin)
+      return true;
+  }
+  return false;
+#if 0 // An equivalent but less inefficient implementation:
   LiveRange Temp;
   Temp.addSegment(OtherBegin, OtherBegin + 1);
   return overlaps(Temp);
+#endif
 }
 
 // Returns true if the live range contains the given instruction
 // number.  This is only used for validating the live range
 // calculation.
 bool LiveRange::containsValue(InstNumberT Value) const {
   for (RangeType::const_iterator I = Range.begin(), E = Range.end(); I != E;
        ++I) {
     if (I->first <= Value && Value <= I->second)
       return true;
@@ skipping 114 matching lines @@
   case MDS_MultiDefMultiBlock:
   case MDS_MultiDefSingleBlock:
     return NULL;
   case MDS_SingleDef:
     assert(!Definitions.empty());
     return Definitions[0];
   }
 }
 
 void VariablesMetadata::init() {
+  static TimerIdT IDvmetadata = GlobalContext::getTimerID("vmetadata");
+  TimerMarker T(IDvmetadata, Func->getContext());
   Metadata.clear();
   Metadata.resize(Func->getNumVariables());
 
   // Mark implicit args as being used in the entry node.
   const VarList &ImplicitArgList = Func->getImplicitArgs();
   for (VarList::const_iterator I = ImplicitArgList.begin(),
                                E = ImplicitArgList.end();
        I != E; ++I) {
     const Variable *Var = *I;
     const Inst *NoInst = NULL;
@@ skipping 164 matching lines @@
 
 Ostream &operator<<(Ostream &Str, const RegWeight &W) {
   if (W.getWeight() == RegWeight::Inf)
     Str << "Inf";
   else
     Str << W.getWeight();
   return Str;
 }
 
 } // end of namespace Ice