Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 610753002: Revert of Suppress Uninitialized access in ExtensionManagement::Refresh (Closed)

Created:
6 years, 2 months ago by hans
Modified:
6 years, 2 months ago
Reviewers:
oshima, miu
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress Uninitialized access in ExtensionManagement::Refresh (patchset #2 id:20001 of https://codereview.chromium.org/608063002/) Reason for revert: The Clang roll that caused the Valgrind error was reverted in https://chromium.googlesource.com/chromium/src/+/3c80ac9fd48da3d11852eecd6999053d6d84c56c Original issue's description: > Suppress Uninitialized access in ExtensionManagement::Refresh > > BUG=418234 > TBR=miu@chromium.org > > Committed: https://crrev.com/459b9796ff2ba105e8a6bae4c7e63508ea83bb67 > Cr-Commit-Position: refs/heads/master@{#297028} TBR=miu@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=418234 Committed: https://crrev.com/830628b83527701019e94e2d5f75d4dc4c3cb5b0 Cr-Commit-Position: refs/heads/master@{#297074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
Created Revert of Suppress Uninitialized access in ExtensionManagement::Refresh
6 years, 2 months ago (2014-09-26 23:48:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610753002/1
6 years, 2 months ago (2014-09-26 23:48:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8d252a61fc8c034b34d426a3acf8b223fb92c8c0
6 years, 2 months ago (2014-09-26 23:49:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/830628b83527701019e94e2d5f75d4dc4c3cb5b0 Cr-Commit-Position: refs/heads/master@{#297074}
6 years, 2 months ago (2014-09-26 23:50:30 UTC) #4
miu
6 years, 2 months ago (2014-09-26 23:55:19 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698