Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 610733002: Rename kWebMEncryptInitDataType to kWebMInitDataType (Closed)

Created:
6 years, 2 months ago by sandersd (OOO until July 31)
Modified:
6 years, 2 months ago
Reviewers:
jrummell, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename kWebMEncryptInitDataType to kWebMInitDataType Committed: https://crrev.com/9fbdec83ad5a77429c3a11b0d5a34cf9d2305752 Cr-Commit-Position: refs/heads/master@{#297949}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add back webm_crypto_helpers.h changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_crypto_helpers.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
sandersd (OOO until July 31)
6 years, 2 months ago (2014-09-26 23:10:32 UTC) #2
jrummell
I'm not sure what this improves, but lgtm.
6 years, 2 months ago (2014-09-26 23:46:25 UTC) #3
sandersd (OOO until July 31)
ddorwin@chromium.org: Please review changes in
6 years, 2 months ago (2014-09-26 23:49:34 UTC) #5
ddorwin
LGTM jrummell, this was identified in another review. The current name is strange and inconsistent ...
6 years, 2 months ago (2014-09-26 23:52:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610733002/20001
6 years, 2 months ago (2014-10-02 22:02:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/4619)
6 years, 2 months ago (2014-10-02 22:16:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610733002/40001
6 years, 2 months ago (2014-10-02 22:27:13 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 2ca8540de430015920feaa38071e66ad1b1326cd
6 years, 2 months ago (2014-10-02 23:34:02 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 23:37:10 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9fbdec83ad5a77429c3a11b0d5a34cf9d2305752
Cr-Commit-Position: refs/heads/master@{#297949}

Powered by Google App Engine
This is Rietveld 408576698