Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 610703002: Link VPX into GN build more. (Closed)

Created:
6 years, 2 months ago by brettw
Modified:
6 years, 2 months ago
Reviewers:
Sergey Ulanov, jamesr
CC:
chromium-reviews, darin-cc_chromium.org, jam, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Link VPX into GN build more. These cases were commented out (VPX used to not work). They should now match the GYP build. I think these deps aren't strictly necessary because dependent targets link vpx in, but it's a good idea to match GYP, and I think this will make the header checker happier. R=jamesr@chromium.org Committed: https://crrev.com/362af2a51901c1460d208a2ffb861da9943478a9 Cr-Commit-Position: refs/heads/master@{#297039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
brettw
6 years, 2 months ago (2014-09-26 20:51:07 UTC) #2
jamesr
lgtm
6 years, 2 months ago (2014-09-26 20:51:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610703002/1
6 years, 2 months ago (2014-09-26 20:55:01 UTC) #5
Sergey Ulanov
I assume we can revert https://codereview.chromium.org/501153003 after this change lands. Is that right?
6 years, 2 months ago (2014-09-26 20:55:53 UTC) #7
brettw
On 2014/09/26 20:55:53, Sergey Ulanov wrote: > I assume we can revert https://codereview.chromium.org/501153003 after this ...
6 years, 2 months ago (2014-09-26 20:57:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13890)
6 years, 2 months ago (2014-09-26 21:07:02 UTC) #10
brettw
Committed patchset #1 (id:1) to pending queue manually as 7bfbb23.
6 years, 2 months ago (2014-09-26 21:27:32 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 21:28:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/362af2a51901c1460d208a2ffb861da9943478a9
Cr-Commit-Position: refs/heads/master@{#297039}

Powered by Google App Engine
This is Rietveld 408576698