Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 610683002: Revert of Support for :enabled selector on Anchor & Area elements (Closed)

Created:
6 years, 2 months ago by abinader
Modified:
6 years, 2 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Revert of Support for :enabled selector on Anchor & Area elements (patchset #2 id:20001 of https://codereview.chromium.org/408293002/) Reason for revert: HTML spec has been modified [1] to disable support for :enabled CSS selector on Anchor, Area & Link elements, after discussion on W3C Bugzilla [2]. [1] https://html5.org/r/8818 [2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=26622 Original issue's description: > Support for :enabled selector on Anchor & Area elements > > Updates the PseudoEnabled selector checker to check for Anchor & Area > elements with a link. Reverts ef7563d45ca529252c4caa612dece0ddb1dcfc1d > which removed relevant Shadow DOM tests. > > Spec: http://html.spec.whatwg.org/#selector-enabled > > BUG=393105 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179427 TBR=esprehn@chromium.org,alexis.menard@intel.com,dglazkov@chromium.org,jchaffraix@chromium.org BUG=393105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182932

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -96 lines) Patch
D LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor-expected.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-area.html View 1 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-area-expected.html View 1 1 chunk +0 lines, -25 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
abinader
Created Revert of Support for :enabled selector on Anchor & Area elements
6 years, 2 months ago (2014-09-26 18:43:40 UTC) #1
rune
You should remove these two lines too: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp&l=198-199
6 years, 2 months ago (2014-09-26 19:12:43 UTC) #3
abinader
On 2014/09/26 19:12:43, rune wrote: > You should remove these two lines too: > > ...
6 years, 2 months ago (2014-09-26 20:28:52 UTC) #4
rune
On 2014/09/26 at 20:28:52, bruno.d wrote: > On 2014/09/26 19:12:43, rune wrote: > > You ...
6 years, 2 months ago (2014-09-29 20:36:50 UTC) #5
abinader
On 2014/09/29 20:36:50, rune wrote: > On 2014/09/26 at 20:28:52, bruno.d wrote: > > On ...
6 years, 2 months ago (2014-09-30 12:38:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610683002/170001
6 years, 2 months ago (2014-09-30 15:20:03 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 15:53:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:170001) as 182932

Powered by Google App Engine
This is Rietveld 408576698