Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java

Issue 610673002: Expose startNetLog / stopNetLog from HttpUrlRequestFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java
diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java
index a500fd7f3510781bda33ec093190f29d01ed104a..55736c2ef0957175443cd28450d46a0719a8d098 100644
--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java
+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java
@@ -59,6 +59,20 @@ public abstract class HttpUrlRequestFactory {
int requestPriority, Map<String, String> headers,
WritableByteChannel channel, HttpUrlRequestListener listener);
+ /**
+ * Starts NetLog logging to a file named |fileName| in the
+ * application temporary directory. |fileName| must not be empty. Log may
+ * contain user's personal information (PII). If the file exists it is
+ * truncated before starting. If actively logging the call is ignored.
+ */
+ public abstract void startNetLogToFile(String fileName);
+
+ /**
+ * Stops NetLog logging and flushes file to disk. If a logging session is
+ * not in progress this call is ignored.
+ */
+ public abstract void stopNetLog();
+
private static HttpUrlRequestFactory createChromiumFactory(
Context context, HttpUrlRequestFactoryConfig config) {
HttpUrlRequestFactory factory = null;

Powered by Google App Engine
This is Rietveld 408576698