components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java - Issue 610673002: Expose startNetLog / stopNetLog from HttpUrlRequestFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java

Issue 610673002: Expose startNetLog / stopNetLog from HttpUrlRequestFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java ('K') | « components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java

index 1d4c31224ca4e154b8a0d1f9317613b880942448..80a9c2fe0977713119c067756ee95d80e7b2d792 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java

@@ -84,11 +84,10 @@ public class CronetUrlTest extends CronetTestBase {

waitForActiveShellToBeDoneLoading();

File file = File.createTempFile("cronet", "json");

- activity.mChromiumRequestFactory.getRequestContext().startNetLogToFile(

- file.getPath());

+ activity.mRequestFactory.startNetLogToFile(file.getPath());

activity.startWithURL(URL);

Thread.sleep(5000);

- activity.mChromiumRequestFactory.getRequestContext().stopNetLog();

+ activity.mRequestFactory.stopNetLog();

assertTrue(file.exists());

assertTrue(file.length() != 0);

assertTrue(file.delete());