chrome/browser/apps/web_view_browsertest.cc - Issue 610643003: Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 610643003: Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/web_view_browsertest.cc

diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc

index fed212dcf4e7ce7eb410c87f7d9c37466e9fe46c..dde5e2c1c14e57bdecd0f34589bcf9dec985ec49 100644

--- a/chrome/browser/apps/web_view_browsertest.cc

+++ b/chrome/browser/apps/web_view_browsertest.cc

@@ -2260,6 +2260,10 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestFindAPI_findupdate) {

TestHelper("testFindAPI_findupdate", "web_view/shim", NO_TEST_SERVER);

}

+IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestLoadDataAPI) {

+ TestHelper("testLoadDataAPI", "web_view/shim", NEEDS_TEST_SERVER);

// <webview> screenshot capture fails with ubercomp.

// See http://crbug.com/327035.

IN_PROC_BROWSER_TEST_F(WebViewCaptureTest,

« no previous file with comments | « no previous file | chrome/common/extensions/api/webview_tag.json » ('j') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('J')