Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: components/nacl/browser/nacl_browser_delegate.h

Issue 61063003: Keep NaCl plugins used in app background pages alive when active. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move callback impl to nacl_browser_delegate_impl.cc. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/nacl_browser_delegate.h
diff --git a/components/nacl/common/nacl_browser_delegate.h b/components/nacl/browser/nacl_browser_delegate.h
similarity index 86%
rename from components/nacl/common/nacl_browser_delegate.h
rename to components/nacl/browser/nacl_browser_delegate.h
index 10d014801566d3df2359a68982f189a40cbb9771..08e82df6db49b58932520b6bea9d013917cb5325 100644
--- a/components/nacl/common/nacl_browser_delegate.h
+++ b/components/nacl/browser/nacl_browser_delegate.h
@@ -2,12 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_NACL_COMMON_NACL_BROWSER_DELEGATE_H_
-#define COMPONENTS_NACL_COMMON_NACL_BROWSER_DELEGATE_H_
+#ifndef COMPONENTS_NACL_BROWSER_NACL_BROWSER_DELEGATE_H_
+#define COMPONENTS_NACL_BROWSER_NACL_BROWSER_DELEGATE_H_
#include <string>
#include "base/callback_forward.h"
+// Include because nested OnIdleChangeCallback class can't be forward declared.
+#include "content/public/browser/browser_ppapi_host.h"
class GURL;
@@ -21,10 +23,6 @@ class HostFactory;
}
}
-namespace content {
-class BrowserPpapiHost;
-}
-
// Encapsulates the dependencies of NaCl code on chrome/, to avoid a direct
// dependency on chrome/.
class NaClBrowserDelegate {
@@ -73,6 +71,10 @@ class NaClBrowserDelegate {
// Returns whether NaCl application with this manifest URL should be debugged.
virtual bool URLMatchesDebugPatterns(const GURL& manifest_url) = 0;
+
+ // Returns a callback that handles NaCl idle state transitions.
+ virtual const content::BrowserPpapiHost::OnIdleChangeCallback
yzshen1 2013/11/21 18:01:50 Why do we need 'const' here?
scheib 2013/12/11 21:35:40 Done.
+ GetOnIdleChangeCallback() = 0;
};
-#endif // COMPONENTS_NACL_COMMON_NACL_BROWSER_DELEGATE_H_
+#endif // COMPONENTS_NACL_BROWSER_NACL_BROWSER_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698