Keep NaCl plugins used in app background pages alive when active.

ppapi/thunk/enter.cc

Index: ppapi/thunk/enter.cc
diff --git a/ppapi/thunk/enter.cc b/ppapi/thunk/enter.cc
index 47889dd15776c7b4feadada713b8496f835611bb..2adc7f2d47a88239af5bcfdff77263c5363b7062 100644
--- a/ppapi/thunk/enter.cc
+++ b/ppapi/thunk/enter.cc
@@ -32,16 +32,19 @@ namespace subtle {
 EnterBase::EnterBase()
     : resource_(NULL),
       retval_(PP_OK) {
+  PpapiGlobals::Get()->MarkPluginIsActive();
 }
 
 EnterBase::EnterBase(PP_Resource resource)
     : resource_(GetResource(resource)),
       retval_(PP_OK) {
+  PpapiGlobals::Get()->MarkPluginIsActive();
 }
 
 EnterBase::EnterBase(PP_Instance instance, SingletonResourceID resource_id)
     : resource_(GetSingletonResource(instance, resource_id)),
       retval_(PP_OK) {
+  PpapiGlobals::Get()->MarkPluginIsActive();
 }
 
 EnterBase::EnterBase(PP_Resource resource,
@@ -49,6 +52,7 @@ EnterBase::EnterBase(PP_Resource resource,
     : resource_(GetResource(resource)),
       retval_(PP_OK) {
   callback_ = new TrackedCallback(resource_, callback);
+  PpapiGlobals::Get()->MarkPluginIsActive();
 }
 
 EnterBase::EnterBase(PP_Instance instance, SingletonResourceID resource_id,
@@ -59,6 +63,7 @@ EnterBase::EnterBase(PP_Instance instance, SingletonResourceID resource_id,
   if (!resource_)
     retval_ = PP_ERROR_BADARGUMENT;
   callback_ = new TrackedCallback(resource_, callback);
+  PpapiGlobals::Get()->MarkPluginIsActive();

[dmichael (off chromium), 2013/11/06 22:39:21]

In these latter 4 cases, you either have the instance as an arg, or you can get
it from resource_...

So you could pass it. In some other cases, however (PPB_Var, PPB_Core,
PPB_MessageLoop) we might not have the PP_Instance. Hmm.

I think this is probably good as-is, since we're only doing this for NaCl. But I
think a comment could be good in BrowserPpapiHostImpl::OnIdleState. I'll comment
there as well...

[scheib, 2013/11/15 01:22:17]

Done.

 }
 
 EnterBase::~EnterBase() {