Keep NaCl plugins used in app background pages alive when active.

content/browser/ppapi_plugin_process_host.cc

Index: content/browser/ppapi_plugin_process_host.cc
diff --git a/content/browser/ppapi_plugin_process_host.cc b/content/browser/ppapi_plugin_process_host.cc
index fbf512a7419d877cff880b37cc01af041be6be36..4efa5c42d9dee0a77e8755eaf7996cb85dbc8462 100644
--- a/content/browser/ppapi_plugin_process_host.cc
+++ b/content/browser/ppapi_plugin_process_host.cc
@@ -213,10 +213,10 @@ PpapiPluginProcessHost::PpapiPluginProcessHost(
   process_.reset(new BrowserChildProcessHostImpl(
       PROCESS_TYPE_PPAPI_PLUGIN, this));
 
-  host_impl_.reset(new BrowserPpapiHostImpl(this, permissions_, info.name,
-                                            info.path, profile_data_directory,
-                                            false /* in_process */,
-                                            false /* external_plugin */));
+  host_impl_ = new BrowserPpapiHostImpl(NULL, this, permissions_, info.name,
+                                        info.path, profile_data_directory,
+                                        false /* in_process */,
+                                        false /* external_plugin */);
 
   filter_ = new PepperMessageFilter();
   process_->AddFilter(filter_.get());
@@ -237,11 +237,11 @@ PpapiPluginProcessHost::PpapiPluginProcessHost()
   ppapi::PpapiPermissions permissions;  // No permissions.
   // The plugin name, path and profile data directory shouldn't be needed for
   // the broker.
-  host_impl_.reset(new BrowserPpapiHostImpl(this, permissions,
-                                            std::string(), base::FilePath(),
-                                            base::FilePath(),
-                                            false /* in_process */,
-                                            false /* external_plugin */));
+  host_impl_ = new BrowserPpapiHostImpl(NULL, this, permissions,

[dmichael (off chromium), 2013/11/06 22:39:21]

This looks kind of messy, since that argument is only relevant for NaCl (and
even in that case, we don't call this constructor directly). What about not
having that argument? We could instead have either SetDelegate or
SetIdleCallback (I think I prefer the latter).

[scheib, 2013/11/15 01:22:17]

Done.

+                                        std::string(), base::FilePath(),
+                                        base::FilePath(),
+                                        false /* in_process */,
+                                        false /* external_plugin */);
 }
 
 bool PpapiPluginProcessHost::Init(const PepperPluginInfo& info) {