Keep NaCl plugins used in app background pages alive when active.

ppapi/proxy/plugin_main_nacl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <set>
 
 #include "build/build_config.h"
 // Need to include this before most other files because it defines
 // IPC_MESSAGE_LOG_ENABLED. We need to use it to define
 // IPC_MESSAGE_MACROS_LOG_ENABLED so ppapi_messages.h will generate the
 // ViewMsgLog et al. functions.
 
 #include "base/command_line.h"
+#include "base/debug/trace_event.h"
 #include "base/message_loop/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/thread.h"
 #include "components/tracing/child_trace_message_filter.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_logging.h"
 #include "ipc/ipc_message.h"
 #include "native_client/src/shared/srpc/nacl_srpc.h"
 #include "native_client/src/untrusted/irt/irt_ppapi.h"
 #include "ppapi/c/ppp.h"
@@ skipping 234 matching lines @@
 
 }  // namespace
 
 void PpapiPluginRegisterThreadCreator(
     const struct PP_ThreadFunctions* thread_functions) {
   // Initialize all classes that need to create threads that call back into
   // user code.
   ppapi::PPB_Audio_Shared::SetThreadFunctions(thread_functions);
 }
 
+const int checkIntervalInSeconds = 1;

[yzshen1, 2013/11/06 22:43:15]

Please use kCheck....

Shall we put these two variable in the anonymous namespace?

[scheib, 2013/11/15 01:22:17]

Done.

+bool last_was_active = false;
+
+void CheckActivity(base::MessageLoop* loop, PpapiDispatcher* dispatcher) {

[yzshen1, 2013/11/06 22:43:15]

|dispatcher| is not needed, right?

[scheib, 2013/11/15 01:22:17]

Done.

+  bool was_active = PluginGlobals::Get()->plugin_has_been_active();

[yzshen1, 2013/11/06 22:43:15]

You need to lock the pepper proxy lock before you can access PluginGlobals.

Please see ProxyAutoLock.

[scheib, 2013/11/15 01:22:17]

Done.

+  PluginGlobals::Get()->set_plugin_has_been_active(false);
+
+  if (last_was_active != was_active) {
+    PluginGlobals::Get()->GetBrowserSender()->Send(
+        new PpapiHostMsg_IdleState(!was_active));
+  }
+  last_was_active = was_active;
+
+  loop->PostDelayedTask(FROM_HERE, base::Bind(&CheckActivity, loop, dispatcher),

[yzshen1, 2013/11/06 22:43:15]

nit: you could use MessageLoop::current() instead of passing |loop|.

[scheib, 2013/11/15 01:22:17]

Done.

+                        base::TimeDelta::FromSeconds(checkIntervalInSeconds));
+}
+
 int PpapiPluginMain() {
   // Though it isn't referenced here, we must instantiate an AtExitManager.
   base::AtExitManager exit_manager;
   base::MessageLoop loop;
   IPC::Logging::set_log_function_map(&g_log_function_mapping);
   ppapi::proxy::PluginGlobals plugin_globals;
   base::Thread io_thread("Chrome_NaClIOThread");
   base::Thread::Options options;
   options.message_loop_type = base::MessageLoop::TYPE_IO;
   io_thread.StartWithOptions(options);
 
   // Start up the SRPC server on another thread. Otherwise, when it blocks
   // on an RPC, the PPAPI proxy will hang. Do this before we initialize the
   // module and start the PPAPI proxy so that the NaCl plugin can continue
   // loading the app.
   static struct NaClSrpcHandlerDesc srpc_methods[] = { { NULL, NULL } };
   if (!NaClSrpcAcceptClientOnThread(srpc_methods)) {
     return 1;
   }
 
   PpapiDispatcher ppapi_dispatcher(io_thread.message_loop_proxy());
   plugin_globals.set_plugin_proxy_delegate(&ppapi_dispatcher);
 
+  io_thread.message_loop()->PostDelayedTask(FROM_HERE,
+                                            base::Bind(&CheckActivity,
+                                                       io_thread.message_loop(),
+                                                       &ppapi_dispatcher),
+                       base::TimeDelta::FromSeconds(checkIntervalInSeconds));

[yzshen1, 2013/11/06 22:43:15]

wrong indent.

[scheib, 2013/11/15 01:22:17]

Done.

   loop.Run();
 
   return 0;
 }