Keep NaCl plugins used in app background pages alive when active.

chrome/browser/nacl_host/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/nacl_host/nacl_process_host.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/process/process_iterator.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/windows_version.h"
 #include "build/build_config.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/nacl_host/nacl_host_message_filter.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/nacl/browser/nacl_browser.h"
 #include "components/nacl/common/nacl_cmd_line.h"
 #include "components/nacl/common/nacl_host_messages.h"
 #include "components/nacl/common/nacl_messages.h"
 #include "components/nacl/common/nacl_process_type.h"
 #include "components/nacl/common/nacl_switches.h"
 #include "content/public/browser/browser_child_process_host.h"
 #include "content/public/browser/browser_ppapi_host.h"
 #include "content/public/browser/child_process_data.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/site_instance.h"
 #include "content/public/common/child_process_host.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/process_type.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_switches.h"
 #include "native_client/src/shared/imc/nacl_imc_c.h"
 #include "net/base/net_util.h"
 #include "net/socket/tcp_listen_socket.h"
 #include "ppapi/host/host_factory.h"
 #include "ppapi/host/ppapi_host.h"
@@ skipping 713 matching lines @@
 }
 
 bool NaClProcessHost::SendStart() {
   if (!enable_ppapi_proxy()) {
     if (!ReplyToRenderer(IPC::ChannelHandle()))
       return false;
   }
   return StartNaClExecution();
 }
 
+class BrowserPpapiHostDelegate : public content::BrowserPpapiHost::Delegate {
+  virtual void OnIdleState(bool idle,

[dmichael (off chromium), 2013/11/06 22:39:21]

OnIdleStateChange?
OnIdleStateTransition?

[scheib, 2013/11/15 01:22:17]

Done: IdleStateChange

+                           const base::FilePath& profile_data_directory,
+                           const content::RenderViewHost* render_view_host,
+                           const GURL& document_url) OVERRIDE {
+    DCHECK(render_view_host);
+    if (!render_view_host)
+      return;
+
+    content::SiteInstance* site_instance = render_view_host->GetSiteInstance();
+    DCHECK(site_instance);
+    if (!site_instance)
+      return;
+
+    extensions::ExtensionSystem* extension_system =
+        extensions::ExtensionSystem::GetForBrowserContext(
+            site_instance->GetBrowserContext());
+    DCHECK(extension_system);
+    if (!extension_system)
+      return;
+
+    const ExtensionService* extension_service =
+        extension_system->extension_service();
+    DCHECK(extension_service);
+    if (!extension_service)
+      return;
+
+    const extensions::Extension* extension = 
+      extension_service->GetExtensionById(document_url.host(), false);
+    DCHECK(extension);
+    if (!extension)
+      return;
+
+    ExtensionProcessManager* pm = extension_system->process_manager();
+    DCHECK(pm);
+    if (!pm)
+      return;
+
+    if (idle) {
+      fprintf(stderr, "%s:%s:%d DecrementLazyKeepaliveCount\n", __FILE__, __FUNCTION__, __LINE__); 
+      pm->DecrementLazyKeepaliveCount(extension);
+    } else {
+      fprintf(stderr, "%s:%s:%d IncrementLazyKeepaliveCount\n", __FILE__, __FUNCTION__, __LINE__); 
+      pm->IncrementLazyKeepaliveCount(extension);
+    }
+  }
+};

[dmichael (off chromium), 2013/11/06 22:39:21]

This should probably go up in the unnamed namespace.

[scheib, 2013/11/15 01:22:17]

Done.

+
 // This method is called when NaClProcessHostMsg_PpapiChannelCreated is
 // received or PpapiHostMsg_ChannelCreated is forwarded by our plugin
 // listener.
 void NaClProcessHost::OnPpapiChannelCreated(
     const IPC::ChannelHandle& channel_handle) {
   // Only renderer processes should create a channel.
   DCHECK(enable_ppapi_proxy());
   // If the proxy channel is null, this must be the initial NaCl-Browser IPC
   // channel.
   if (!ipc_proxy_channel_.get()) {
     DCHECK_EQ(PROCESS_TYPE_NACL_LOADER, process_->GetData().process_type);
 
     ipc_proxy_channel_.reset(
         new IPC::ChannelProxy(channel_handle,
                               IPC::Channel::MODE_CLIENT,
                               &ipc_plugin_listener_,
                               base::MessageLoopProxy::current().get()));
     // Create the browser ppapi host and enable PPAPI message dispatching to the
     // browser process.
-    ppapi_host_.reset(content::BrowserPpapiHost::CreateExternalPluginProcess(
+    ppapi_host_ = content::BrowserPpapiHost::CreateExternalPluginProcess(
+        new BrowserPpapiHostDelegate(),
         ipc_proxy_channel_.get(),  // sender
         permissions_,
         process_->GetData().handle,
         ipc_proxy_channel_.get(),
         nacl_host_message_filter_->render_process_id(),
         render_view_id_,
-        profile_directory_));
+        profile_directory_);
 
     ppapi::PpapiNaClChannelArgs args;
     args.off_the_record = nacl_host_message_filter_->off_the_record();
     args.permissions = permissions_;
     CommandLine* cmdline = CommandLine::ForCurrentProcess();
     DCHECK(cmdline);
     std::string flag_whitelist[] = {switches::kV, switches::kVModule};
     for (size_t i = 0; i < arraysize(flag_whitelist); ++i) {
       std::string value = cmdline->GetSwitchValueASCII(flag_whitelist[i]);
       if (!value.empty()) {
@@ skipping 205 matching lines @@
   } else {
     NaClStartDebugExceptionHandlerThread(
         process_handle.Take(), info,
         base::MessageLoopProxy::current(),
         base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
                    weak_factory_.GetWeakPtr()));
     return true;
   }
 }
 #endif