Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 610613002: mojo: Add promises for python bindings. (Closed)

Created:
6 years, 2 months ago by qsr
Modified:
6 years, 2 months ago
Reviewers:
Chris Masone, sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Add promises for python bindings. This CL introduces promise for the python bindings. The API is following ECMAScript 6. BUG=418109 R=sdefresne@chromium.org,cmasone@chromium.org Committed: https://crrev.com/45a1583ba9f782ae59d739d74727774089c77868 Cr-Commit-Position: refs/heads/master@{#297402}

Patch Set 1 #

Patch Set 2 : Fix ECMAScript #

Total comments: 2

Patch Set 3 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -0 lines) Patch
M mojo/mojo.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/python/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/python/mojo/bindings/promise.py View 1 2 1 chunk +188 lines, -0 lines 0 comments Download
A mojo/python/tests/promise_unittest.py View 1 2 1 chunk +181 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
qsr
6 years, 2 months ago (2014-09-26 15:08:16 UTC) #1
sdefresne
lgtm https://codereview.chromium.org/610613002/diff/20001/mojo/public/python/mojo/bindings/promise.py File mojo/public/python/mojo/bindings/promise.py (right): https://codereview.chromium.org/610613002/diff/20001/mojo/public/python/mojo/bindings/promise.py#newcode39 mojo/public/python/mojo/bindings/promise.py:39: @classmethod nit: Since you don't use "cls" but ...
6 years, 2 months ago (2014-09-30 07:53:43 UTC) #2
qsr
https://codereview.chromium.org/610613002/diff/20001/mojo/public/python/mojo/bindings/promise.py File mojo/public/python/mojo/bindings/promise.py (right): https://codereview.chromium.org/610613002/diff/20001/mojo/public/python/mojo/bindings/promise.py#newcode39 mojo/public/python/mojo/bindings/promise.py:39: @classmethod On 2014/09/30 07:53:43, sdefresne wrote: > nit: Since ...
6 years, 2 months ago (2014-09-30 08:25:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610613002/40001
6 years, 2 months ago (2014-09-30 10:41:41 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e5410dc268756422966582d3ca75ed94e0bfe7e1
6 years, 2 months ago (2014-09-30 11:22:19 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 11:23:00 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/45a1583ba9f782ae59d739d74727774089c77868
Cr-Commit-Position: refs/heads/master@{#297402}

Powered by Google App Engine
This is Rietveld 408576698