Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: cc/output/gl_renderer.cc

Issue 610603003: cc: Removed DCHECK that asserted MapPoint returns clipped as true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a comment eplaining why we ignore clipped Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index 6bb6f439ed849eb831c38c3287eaa776d4160f6d..a29cb205d8e02fe856b36536b7a3da4609f2bb8f 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -1421,15 +1421,13 @@ bool GLRenderer::SetupQuadForAntialiasing(
gfx::PointF top_left = tile_rect.origin();
gfx::PointF top_right = tile_rect.top_right();
- // Map points to device space.
+ // Map points to device space. We ignore |clipped|, since the result of
+ // |MapPoint()| still produces a valid point to draw the quad with. When
+ // clipped, the point will be outside of the viewport. See crbug.com/416367.
bottom_right = MathUtil::MapPoint(device_transform, bottom_right, &clipped);
- DCHECK(!clipped);
bottom_left = MathUtil::MapPoint(device_transform, bottom_left, &clipped);
- DCHECK(!clipped);
top_left = MathUtil::MapPoint(device_transform, top_left, &clipped);
- DCHECK(!clipped);
top_right = MathUtil::MapPoint(device_transform, top_right, &clipped);
- DCHECK(!clipped);
LayerQuad::Edge bottom_edge(bottom_right, bottom_left);
LayerQuad::Edge left_edge(bottom_left, top_left);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698