Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 610593002: Avoid repeated code when building SVG help tables. (Closed)

Created:
6 years, 2 months ago by Daniel Bratell
Modified:
6 years, 2 months ago
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid repeated code when building SVG help tables. This saves roughly 6 KB of code. Grown symbols: +123: blink::SVGFontFaceElement::parseAttribute(blink::QualifiedName const&, WTF::AtomicString const&) type=t, (was 330 bytes, now 453 bytes) Removed symbols: -94: blink::mapAttributeToCSSProperty(WTF::HashMap<WTF::StringImpl*, blink::CSSPropertyID, WTF::StringHash, WTF::HashTraits<WTF::StringImpl*>, WTF::HashTraits<blink::CSSPropertyID>, WTF::DefaultAllocator>*, blink::QualifiedName const&) type=t, size=94 bytes Shrunk symbols: -2121: blink::SVGElement::animatedPropertyTypeForCSSAttribute(blink::QualifiedName const&) type=t, (was 3795 bytes, now 1674 bytes) -3786: blink::SVGElement::cssPropertyIdForSVGAttributeName(blink::QualifiedName const&) type=t, (was 5076 bytes, now 1290 bytes) R=fs@opera.com BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -249 lines) Patch
M Source/core/svg/SVGElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 4 chunks +226 lines, -214 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 2 chunks +41 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Daniel Bratell
6 years, 2 months ago (2014-09-26 14:15:33 UTC) #3
Daniel Bratell
6 years, 2 months ago (2014-09-26 14:18:29 UTC) #4
fs
lgtm
6 years, 2 months ago (2014-09-30 08:38:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610593002/1
6 years, 2 months ago (2014-09-30 09:36:57 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 10:13:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182903

Powered by Google App Engine
This is Rietveld 408576698