Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 610523002: linux: Fixes a racy crash by key input at termination. (Closed)

Created:
6 years, 2 months ago by Yuki
Modified:
6 years, 2 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

linux: Fixes a racy crash by key input at termination. It seems that it's possible that GDK events happen while we're going to unregister the GDK event handler, and the code must be thread-safe. (A gpointer |data| in the old code seems pointing to the deleted object.) This CL removes use of |data| pointer and makes the code thread-safe without adding any mutex. BUG=417210 Committed: https://crrev.com/1291d0c2e4435561edcc260aa0b3337dbd583eda Cr-Commit-Position: refs/heads/master@{#297112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_event_loop.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_event_loop.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yuki
Could you review this CL?
6 years, 2 months ago (2014-09-26 06:01:15 UTC) #2
Elliot Glaysher
lgtm
6 years, 2 months ago (2014-09-26 17:25:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610523002/1
6 years, 2 months ago (2014-09-27 11:44:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6a229e2485fbcf4b541ee32209bb76c3d563c6c0
6 years, 2 months ago (2014-09-27 11:57:02 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 11:57:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1291d0c2e4435561edcc260aa0b3337dbd583eda
Cr-Commit-Position: refs/heads/master@{#297112}

Powered by Google App Engine
This is Rietveld 408576698