Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 610483002: Handle the case freq state data read from file is empty for sysfs_power_montior. (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Handle the case freq state data read from file is empty for sysfs_power_montior. Breakage caused by this case can be found in http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1416/steps/page_cycler.bloat/logs/stdio BUG= Committed: https://crrev.com/d353816643b2e69c699dfb2c54af460f714c3f25 Cr-Commit-Position: refs/heads/master@{#296861}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor_unittest.py View 5 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
6 years, 2 months ago (2014-09-25 23:48:12 UTC) #2
tonyg
lgtm https://codereview.chromium.org/610483002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/610483002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py#newcode161 tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py:161: if (not initial[cpu]) or (not final[cpu]): nit: I ...
6 years, 2 months ago (2014-09-26 00:05:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610483002/20001
6 years, 2 months ago (2014-09-26 00:37:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 49b6f8fecceba002dd80766fb5e343a8945b0dbf
6 years, 2 months ago (2014-09-26 02:25:24 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 02:26:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d353816643b2e69c699dfb2c54af460f714c3f25
Cr-Commit-Position: refs/heads/master@{#296861}

Powered by Google App Engine
This is Rietveld 408576698