Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 610443002: [Android] Disable enhanced bookmark opt-in flag. (Closed)

Created:
6 years, 2 months ago by Kibeom Kim (inactive)
Modified:
6 years, 2 months ago
Reviewers:
Ted C, yfriedman
CC:
chromium-reviews, Ian Wen, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Disable enhanced bookmark opt-in flag. We won't launch this feature for M39, so disable public opt-in flag. BUG=416664 Committed: https://crrev.com/5da932e693169900a4a4be346446788aa1944eeb Cr-Commit-Position: refs/heads/master@{#296825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Kibeom Kim (inactive)
6 years, 2 months ago (2014-09-25 21:56:06 UTC) #2
Ted C
lgtm
6 years, 2 months ago (2014-09-25 22:11:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610443002/1
6 years, 2 months ago (2014-09-25 22:14:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as ca505e44fdd7f30c7da25eb2d11807af6f3f2354
6 years, 2 months ago (2014-09-25 23:24:35 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5da932e693169900a4a4be346446788aa1944eeb Cr-Commit-Position: refs/heads/master@{#296825}
6 years, 2 months ago (2014-09-25 23:26:42 UTC) #8
Kibeom Kim (inactive)
6 years, 2 months ago (2014-09-29 21:27:24 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/612203002/ by kkimlabs@chromium.org.

The reason for reverting is: M39 branched, so re-enable the flag on trunk..

Powered by Google App Engine
This is Rietveld 408576698