Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: Source/platform/scroll/ScrollableArea.h

Issue 610423004: Preserve fractional scroll offset for JS scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/scroll/ScrollableArea.h
diff --git a/Source/platform/scroll/ScrollableArea.h b/Source/platform/scroll/ScrollableArea.h
index 23d846071e8a9c4af477b59b8373b247fa13974e..10eac6fa1cd1ef6b1c93699575fda11a634d6bc4 100644
--- a/Source/platform/scroll/ScrollableArea.h
+++ b/Source/platform/scroll/ScrollableArea.h
@@ -264,7 +264,8 @@ private:
// call into the IntPoint version. If fractional scroll is needed, one
// can override the DoublePoint version to take advantage of the double
// precision scroll offset.
- // FIXME: Remove the IntPoint version. crbug.com/414283.
+ // FIXME: Remove the IntPoint version. And change the function to
+ // take DoubleSize. crbug.com/414283.
virtual void setScrollOffset(const IntPoint&) = 0;
virtual void setScrollOffset(const DoublePoint& offset)
{
« Source/core/rendering/RenderBox.cpp ('K') | « Source/platform/scroll/ScrollView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698