Source/core/html/HTMLBodyElement.cpp - Issue 610423004: Preserve fractional scroll offset for JS scrolling API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLBodyElement.cpp

Issue 610423004: Preserve fractional scroll offset for JS scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLBodyElement.cpp

diff --git a/Source/core/html/HTMLBodyElement.cpp b/Source/core/html/HTMLBodyElement.cpp

index adf218d28de9592c465077971de021860214291b..5702114e9b3a8bd42ddfbcd9c6ecac2499acbfa6 100644

--- a/Source/core/html/HTMLBodyElement.cpp

+++ b/Source/core/html/HTMLBodyElement.cpp

@@ -266,7 +266,7 @@ void HTMLBodyElement::setScrollLeft(double scrollLeft)

FrameView* view = frame->view();

if (!view)

return;

- view->setScrollPosition(IntPoint(static_cast<int>(scrollLeft * frame->pageZoomFactor()), view->scrollY()));

+ view->setScrollPosition(DoublePoint(scrollLeft * frame->pageZoomFactor(), view->scrollY()));

}

double HTMLBodyElement::scrollTop()

@@ -313,7 +313,7 @@ void HTMLBodyElement::setScrollTop(double scrollTop)

FrameView* view = frame->view();

if (!view)

return;

- view->setScrollPosition(IntPoint(view->scrollX(), static_cast<int>(scrollTop * frame->pageZoomFactor())));

+ view->setScrollPosition(DoublePoint(view->scrollX(), scrollTop * frame->pageZoomFactor()));

}

int HTMLBodyElement::scrollHeight()

« no previous file with comments | « Source/core/frame/PinchViewport.cpp ('k') | Source/core/html/ImageDocument.cpp » ('j') | no next file with comments »