Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: LayoutTests/fast/events/scale-and-scroll-div.html

Issue 610423004: Preserve fractional scroll offset for JS scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/events/scale-and-scroll-div-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <style> 4 <style>
5 ::-webkit-scrollbar { 5 ::-webkit-scrollbar {
6 width: 0px; 6 width: 0px;
7 height: 0px; 7 height: 0px;
8 } 8 }
9 #bluebox { 9 #bluebox {
10 width: 100px; 10 width: 100px;
11 height: 100px; 11 height: 100px;
12 background: blue; 12 background: blue;
13 padding: 0px; 13 padding: 0px;
14 margin: 0px; 14 margin: 0px;
15 } 15 }
16 #redbox { 16 #redbox {
17 width: 100px; 17 width: 100px;
18 height: 100px; 18 height: 100px;
19 background: red; 19 background: red;
20 padding: 0px; 20 padding: 0px;
21 margin: 0px; 21 margin: 0px;
22 } 22 }
23 </style> 23 </style>
24 <script> 24 <script>
25 25
26 var floatPrecision = 0.1;
26 var scrollDistance = 10; 27 var scrollDistance = 10;
27 var expectedScrollDistance; 28 var expectedScrollDistance;
28 var scrollBox; 29 var scrollBox;
29 30
30 function scroll(scaleFactor) { 31 function scroll(scaleFactor) {
31 expectedScrollDistance = Math.floor(scrollDistance/scaleFactor); 32 expectedScrollDistance = scrollDistance/scaleFactor;
32 33
33 scrollBox.scrollTop = 0; 34 scrollBox.scrollTop = 0;
34 35
35 eventSender.gestureScrollBegin(10, 100); 36 eventSender.gestureScrollBegin(10, 100);
36 for(var i = 0; i < scrollDistance; ++i) { 37 for(var i = 0; i < scrollDistance; ++i) {
37 eventSender.gestureScrollUpdate(0, -1); 38 eventSender.gestureScrollUpdate(0, -1);
38 } 39 }
39 eventSender.gestureScrollEnd(0, 0); 40 eventSender.gestureScrollEnd(0, 0);
40 41
41 shouldBe('scrollBox.scrollTop', 'expectedScrollDistance'); 42 shouldBeCloseTo('scrollBox.scrollTop', expectedScrollDistance, floatPr ecision);
42 43
43 scrollBox.scrollTop = 20; 44 scrollBox.scrollTop = 20;
44 45
45 eventSender.gestureScrollBegin(10, 300); 46 eventSender.gestureScrollBegin(10, 300);
46 for(var i = 0; i < scrollDistance; ++i) { 47 for(var i = 0; i < scrollDistance; ++i) {
47 eventSender.gestureScrollUpdate(0, 1); 48 eventSender.gestureScrollUpdate(0, 1);
48 } 49 }
49 eventSender.gestureScrollEnd(0, 0); 50 eventSender.gestureScrollEnd(0, 0);
50 51
51 expectedScrollDistance = Math.floor(20 - scrollDistance/scaleFactor); 52 expectedScrollDistance = 20 - scrollDistance/scaleFactor;
52 53
53 shouldBe('scrollBox.scrollTop', 'expectedScrollDistance'); 54 shouldBeCloseTo('scrollBox.scrollTop', expectedScrollDistance, floatPr ecision);
54 } 55 }
55 56
56 function scaleWithEventSender(scaleFactor) { 57 function scaleWithEventSender(scaleFactor) {
57 var scaleOffset = 0; 58 var scaleOffset = 0;
58 if (window.eventSender) { 59 if (window.eventSender) {
59 window.eventSender.setPageScaleFactor(scaleFactor, scaleOffset, sca leOffset); 60 window.eventSender.setPageScaleFactor(scaleFactor, scaleOffset, sca leOffset);
60 } 61 }
61 } 62 }
62 63
63 function test() { 64 function test() {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 <div id="redbox"></div> 104 <div id="redbox"></div>
104 <div id="bluebox"></div> 105 <div id="bluebox"></div>
105 <div id="redbox"></div> 106 <div id="redbox"></div>
106 <div id="bluebox"></div> 107 <div id="bluebox"></div>
107 <div id="redbox"></div> 108 <div id="redbox"></div>
108 </div> 109 </div>
109 110
110 <div id="console"></div> 111 <div id="console"></div>
111 </body> 112 </body>
112 </html> 113 </html>
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/events/scale-and-scroll-div-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698