Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 610333002: [WebBlobRegistry] Use char* than WebThreadSafeData (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
Reviewers:
jam, yhirano
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[WebBlobRegistry] Use char* than WebThreadSafeData We don't need to wrap the data with WebThreadSafeData here. Just use a pair of const char* and size_t. This is Chromium side CL Blink side CL: https://codereview.chromium.org/611923002/ R=yhirano,jam BUG=417093 Committed: https://crrev.com/703e7a89e3f4db15967e3710ef7353b484dd0a5b Cr-Commit-Position: refs/heads/master@{#300064}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M content/child/webblobregistry_impl.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/child/webblobregistry_impl.cc View 1 2 1 chunk +16 lines, -11 lines 0 comments Download
M content/test/mock_webblob_registry_impl.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/test/mock_webblob_registry_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
yhirano
lgtm
6 years, 2 months ago (2014-09-29 08:54:22 UTC) #2
tyoshino (SeeGerritForStatus)
jam, please take a look.
6 years, 2 months ago (2014-10-02 03:23:13 UTC) #4
jam
lgtm sorry for the delay
6 years, 2 months ago (2014-10-06 23:24:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610333002/60001
6 years, 2 months ago (2014-10-16 09:14:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64097)
6 years, 2 months ago (2014-10-16 10:19:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610333002/60001
6 years, 2 months ago (2014-10-17 04:50:47 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-17 04:51:25 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 04:52:26 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/703e7a89e3f4db15967e3710ef7353b484dd0a5b
Cr-Commit-Position: refs/heads/master@{#300064}

Powered by Google App Engine
This is Rietveld 408576698