Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 61033005: Use ScopeIsShadowHost when element is in descentant tree of shadow host of scoping node. (Closed)

Created:
7 years, 1 month ago by tasak
Modified:
7 years, 1 month ago
Reviewers:
hayato, dglazkov
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears
Visibility:
Public.

Description

Use ScopeIsShadowHost when element is in descentant tree of shadow host of scoping node. If a given element is a descendant node of scoping node, we should not treat the scoping node as shadow host. However, when the element is distributed and selector has ::content, we need to check the scoping node again, because the element is moved into a descendant tree hosted by the scoping node(=shadow host). BUG=313941 TEST=fast/dom/shadow/style-with-cat.html,fast/dom/shadow/content-pseudo-element-with-hat.html,fast/dom/shadow/content-pseudo-element-with-cat.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -6 lines) Patch
A LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat.html View 1 chunk +122 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat.html View 1 chunk +100 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-cat.html View 2 chunks +21 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-cat-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 5 chunks +8 lines, -5 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tasak
7 years, 1 month ago (2013-11-11 08:55:50 UTC) #1
dglazkov
lgtm.
7 years, 1 month ago (2013-11-11 21:06:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/61033005/1
7 years, 1 month ago (2013-11-12 04:46:53 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 05:38:11 UTC) #4
Message was sent while issue was closed.
Change committed as 161759

Powered by Google App Engine
This is Rietveld 408576698