Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 610323006: Clean up. (Closed)

Created:
6 years, 2 months ago by Xi Han
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Fady Samuel, lfg, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

The web_request_permission.cc has been moved to //extensions, but for some reason its copy is still in //chrome. This CL does a clean up for it. BUG=352293 Committed: https://crrev.com/5fbd3dbd1fba46949bc3802946bff5d0348116b6 Cr-Commit-Position: refs/heads/master@{#297939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -142 lines) Patch
D chrome/browser/extensions/api/web_request/web_request_permissions.cc View 1 chunk +0 lines, -142 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Xi Han
Ken: a very trivial change. Please take a look. Thanks:)
6 years, 2 months ago (2014-10-02 20:22:58 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-02 22:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610323006/1
6 years, 2 months ago (2014-10-02 22:47:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 27f1c74f244d6efc40a7707a0ae7f7bfd1f79166
6 years, 2 months ago (2014-10-02 23:02:59 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 23:04:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fbd3dbd1fba46949bc3802946bff5d0348116b6
Cr-Commit-Position: refs/heads/master@{#297939}

Powered by Google App Engine
This is Rietveld 408576698