Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 610323004: [turbofan] Negated immediates for ARM64 add/sub (Closed)

Created:
6 years, 2 months ago by m.m.capewell
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Negated immediates for ARM64 add/sub Add ARM64 instruction selector support for negating the sense of an arithmetic instruction when its immediate is negative. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24407

Patch Set 1 #

Total comments: 5

Patch Set 2 : Split out addition tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -33 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 7 chunks +24 lines, -5 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 5 chunks +107 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
m.m.capewell
6 years, 2 months ago (2014-09-29 10:45:02 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right): https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode373 src/compiler/arm64/instruction-selector-arm64-unittest.cc:373: if (strstr(dpi.mi.constructor_name, "Add") != NULL) { See comment below. ...
6 years, 2 months ago (2014-09-30 04:47:49 UTC) #3
m.m.capewell
https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right): https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode398 src/compiler/arm64/instruction-selector-arm64-unittest.cc:398: if (strstr(dpi.mi.constructor_name, "Add") != NULL) { I can do ...
6 years, 2 months ago (2014-09-30 17:42:10 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right): https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode398 src/compiler/arm64/instruction-selector-arm64-unittest.cc:398: if (strstr(dpi.mi.constructor_name, "Add") != NULL) { Split it, please.
6 years, 2 months ago (2014-10-01 15:21:47 UTC) #5
m.m.capewell
https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right): https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode398 src/compiler/arm64/instruction-selector-arm64-unittest.cc:398: if (strstr(dpi.mi.constructor_name, "Add") != NULL) { On 2014/10/01 15:21:46, ...
6 years, 2 months ago (2014-10-02 14:43:44 UTC) #6
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-03 18:09:45 UTC) #7
m.m.capewell
6 years, 2 months ago (2014-10-06 10:39:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 manually as 24407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698