Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 610323003: Editing: Null-check in FrameSelection::updteAppearancea (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add unit test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index 04c181c5199020ae4c312cf7dcf5466b32ad776a..b907c405b1363022cd0b86e3e823543e92380022 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -1602,7 +1602,7 @@ void FrameSelection::updateAppearance(ResetCaretBlinkOption option)
if (startPos.isNotNull() && endPos.isNotNull() && selection.visibleStart() != selection.visibleEnd()) {
RenderObject* startRenderer = startPos.deprecatedNode()->renderer();
RenderObject* endRenderer = endPos.deprecatedNode()->renderer();
- if (startRenderer->view() == view && endRenderer->view() == view)
+ if (startRenderer && endRenderer && startRenderer->view() == view && endRenderer->view() == view)
view->setSelection(startRenderer, startPos.deprecatedEditingOffset(), endRenderer, endPos.deprecatedEditingOffset());
}
}
« no previous file with comments | « no previous file | Source/core/editing/FrameSelectionTest.cpp » ('j') | Source/core/editing/FrameSelectionTest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698