tools/gn/input_conversion.cc - Issue 610293003: Replace more for loops in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/input_conversion.cc

Issue 610293003: Replace more for loops in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self review Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/input_conversion.cc

diff --git a/tools/gn/input_conversion.cc b/tools/gn/input_conversion.cc

index 2534f4d8410f21adf8ac669159ff911853d1a544..6369d2dbfa1e7accb8f43a1d8ae0d8f4b13eb0c0 100644

--- a/tools/gn/input_conversion.cc

+++ b/tools/gn/input_conversion.cc

@@ -105,8 +105,8 @@ Value ParseList(const std::string& input, const ParseNode* origin, Err* err) {

as_lines.resize(as_lines.size() - 1);

ret.list_value().reserve(as_lines.size());

- for (size_t i = 0; i < as_lines.size(); i++)

- ret.list_value().push_back(Value(origin, as_lines[i]));

+ for (const auto& line : as_lines)

+ ret.list_value().push_back(Value(origin, line));

return ret;

}