Replace more for loops in GN

tools/gn/visibility.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/visibility.h"
 
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "tools/gn/err.h"
 #include "tools/gn/filesystem_utils.h"
@@ skipping 12 matching lines @@
 bool Visibility::Set(const SourceDir& current_dir,
                      const Value& value,
                      Err* err) {
   patterns_.clear();
 
   if (!value.VerifyTypeIs(Value::LIST, err)) {
     CHECK(err->has_error());
     return false;
   }
 
-  const std::vector<Value>& list = value.list_value();
-  for (size_t i = 0; i < list.size(); i++) {
-    patterns_.push_back(LabelPattern::GetPattern(current_dir, list[i], err));
+  for (const auto& item : value.list_value()) {
+    patterns_.push_back(LabelPattern::GetPattern(current_dir, item, err));
     if (err->has_error())
       return false;
   }
   return true;
 }
 
 void Visibility::SetPublic() {
   patterns_.clear();
   patterns_.push_back(
       LabelPattern(LabelPattern::RECURSIVE_DIRECTORY, SourceDir(),
       std::string(), Label()));
 }
 
 void Visibility::SetPrivate(const SourceDir& current_dir) {
   patterns_.clear();
   patterns_.push_back(
       LabelPattern(LabelPattern::DIRECTORY, current_dir, std::string(),
       Label()));
 }
 
 bool Visibility::CanSeeMe(const Label& label) const {
-  for (size_t i = 0; i < patterns_.size(); i++) {
-    if (patterns_[i].Matches(label))
+  for (const auto& pattern : patterns_) {
+    if (pattern.Matches(label))
       return true;
   }
   return false;
 }
 
 std::string Visibility::Describe(int indent, bool include_brackets) const {
   std::string outer_indent_string(indent, ' ');
 
   if (patterns_.empty())
     return outer_indent_string + "[] (no visibility)\n";
 
   std::string result;
 
   std::string inner_indent_string = outer_indent_string;
   if (include_brackets) {
     result += outer_indent_string + "[\n";
     // Indent the insides more if brackets are requested.
     inner_indent_string += "  ";
   }
 
-  for (size_t i = 0; i < patterns_.size(); i++)
-    result += inner_indent_string + patterns_[i].Describe() + "\n";
+  for (const auto& pattern : patterns_)
+    result += inner_indent_string + pattern.Describe() + "\n";
 
   if (include_brackets)
     result += outer_indent_string + "]\n";
   return result;
 }
 
 // static
 bool Visibility::CheckItemVisibility(const Item* from,
                                      const Item* to,
                                      Err* err) {
@@ skipping 11 matching lines @@
 
 // static
 bool Visibility::FillItemVisibility(Item* item, Scope* scope, Err* err) {
   const Value* vis_value = scope->GetValue(variables::kVisibility, true);
   if (vis_value)
     item->visibility().Set(scope->GetSourceDir(), *vis_value, err);
   else  // Default to public.
     item->visibility().SetPublic();
   return !err->has_error();
 }