Replace more for loops in GN

tools/gn/command_refs.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <set>
 
 #include "base/command_line.h"
 #include "tools/gn/commands.h"
 #include "tools/gn/deps_iterator.h"
@@ skipping 30 matching lines @@
 // Prints the targets which are the result of a query. This list is sorted
 // and, if as_files is set, the unique filenames matching those targets will
 // be used.
 void OutputResultSet(const TargetSet& results, bool as_files) {
   if (results.empty())
     return;
 
   if (as_files) {
     // Output the set of unique source files.
     std::set<std::string> unique_files;
-    for (TargetSet::const_iterator iter = results.begin();
-         iter != results.end(); ++iter)
-      unique_files.insert(FilePathToUTF8(FilePathForItem(*iter)));
+    for (const auto& cur : results)
+      unique_files.insert(FilePathToUTF8(FilePathForItem(cur)));
 
-    for (std::set<std::string>::const_iterator iter = unique_files.begin();
-         iter != unique_files.end(); ++iter) {
-      OutputString(*iter + "\n");
-    }
+    for (const auto& cur : unique_files)
+      OutputString(cur + "\n");
   } else {
     // Output sorted and uniquified list of labels. The set will sort the
     // labels.
     std::set<Label> unique_labels;
-    for (TargetSet::const_iterator iter = results.begin();
-         iter != results.end(); ++iter)
-      unique_labels.insert((*iter)->label());
+    for (const auto& cur : results)
+      unique_labels.insert(cur->label());
 
     // Grab the label of the default toolchain from a random target.
     Label default_tc_label =
         (*results.begin())->settings()->default_toolchain_label();
 
-    for (std::set<Label>::const_iterator iter = unique_labels.begin();
-         iter != unique_labels.end(); ++iter) {
+    for (const auto& cur : unique_labels) {
       // Print toolchain only for ones not in the default toolchain.
-      OutputString(iter->GetUserVisibleName(
-          iter->GetToolchainLabel() != default_tc_label));
+      OutputString(cur.GetUserVisibleName(
+          cur.GetToolchainLabel() != default_tc_label));
       OutputString("\n");
     }
   }
 }
 
 // Prints refs of the given target (not the target itself). If the set is
 // non-null, new targets encountered will be added to the set, and if a ref is
 // in the set already, it will not be recused into. When the set is null, all
 // refs will be printed.
 void RecursivePrintTree(const DepMap& dep_map,
@@ skipping 166 matching lines @@
       // Recursively print all targets.
       RecursivePrintTree(dep_map, query[0], NULL, 0);
     } else {
       // Recursively print unique targets.
       TargetSet seen_targets;
       RecursivePrintTree(dep_map, query[0], &seen_targets, 0);
     }
   } else if (all) {
     // Output recursive dependencies, uniquified and flattened.
     TargetSet results;
-    for (size_t query_i = 0; query_i < query.size(); query_i++)
-      RecursiveCollectChildRefs(dep_map, query[query_i], &results);
+    for (const auto& cur_query : query)
+      RecursiveCollectChildRefs(dep_map, cur_query, &results);
     OutputResultSet(results, files);
   } else {
     // Output direct references of everything in the query.
     TargetSet results;
-    for (size_t query_i = 0; query_i < query.size(); query_i++) {
-      DepMap::const_iterator dep_begin = dep_map.lower_bound(query[query_i]);
-      DepMap::const_iterator dep_end = dep_map.upper_bound(query[query_i]);
+    for (const auto& cur_query : query) {
+      DepMap::const_iterator dep_begin = dep_map.lower_bound(cur_query);
+      DepMap::const_iterator dep_end = dep_map.upper_bound(cur_query);
       for (DepMap::const_iterator cur_dep = dep_begin;
            cur_dep != dep_end; cur_dep++)
         results.insert(cur_dep->second);
     }
     OutputResultSet(results, files);
   }
 
   return 0;
 }
 
 }  // namespace commands