Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 610263002: Prevent a frameless app from sizing itself to 0x0 on Desktop Linux (Closed)

Created:
6 years, 2 months ago by pkotwicz
Modified:
6 years, 2 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, jackhou1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prevent a window from sizing itself to 0x0 using window.resizeTo() on Desktop Linux. Linux generates an X error when it receives a request for 0x0 bounds BUG=416455 TEST=Manual, see bug Committed: https://crrev.com/a8741d0331e34fcefd0810b8101e845e703a12d6 Cr-Commit-Position: refs/heads/master@{#297291}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pkotwicz
erg@ PTAL
6 years, 2 months ago (2014-09-28 19:29:27 UTC) #2
tfarina
https://codereview.chromium.org/610263002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/610263002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1236 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1236: // Do not size a window to 0x0. It ...
6 years, 2 months ago (2014-09-28 19:38:51 UTC) #4
pkotwicz
https://codereview.chromium.org/610263002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/610263002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1236 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1236: // Do not size a window to 0x0. It ...
6 years, 2 months ago (2014-09-28 21:39:49 UTC) #6
Elliot Glaysher
lgtm
6 years, 2 months ago (2014-09-29 18:04:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610263002/60001
6 years, 2 months ago (2014-09-29 21:34:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001) as 0c451d566f1b5bbd72e57370f9ccfe17fd9a4a2a
6 years, 2 months ago (2014-09-29 22:41:56 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 22:45:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8741d0331e34fcefd0810b8101e845e703a12d6
Cr-Commit-Position: refs/heads/master@{#297291}

Powered by Google App Engine
This is Rietveld 408576698