service worker scaffolding

content/browser/service_worker/service_worker_context_core.cc

Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context.cc b/content/browser/service_worker/service_worker_context_core.cc
similarity index 59%
rename from content/browser/service_worker/service_worker_context.cc
rename to content/browser/service_worker/service_worker_context_core.cc
index ed9f669d7f41b421c890b265afd1e481c15e7eea..449474d84f7c8cb5a5c4078fca0114997a38efc5 100644
--- a/content/browser/service_worker/service_worker_context.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -2,24 +2,27 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "content/browser/service_worker/service_worker_context.h"
+#include "content/browser/service_worker/service_worker_context_core.h"
 
 #include "base/files/file_path.h"
 #include "webkit/browser/quota/quota_manager.h"
 
 namespace content {
 
+namespace {
 const base::FilePath::CharType kServiceWorkerDirectory[] =
     FILE_PATH_LITERAL("ServiceWorker");
+}
 
-ServiceWorkerContext::ServiceWorkerContext(
-    const base::FilePath& path,
+ServiceWorkerContextCore::ServiceWorkerContextCore(
+    const base::FilePath& user_data_directory,
     quota::QuotaManagerProxy* quota_manager_proxy)
     : quota_manager_proxy_(quota_manager_proxy) {
-  if (!path.empty())
-    path_ = path.Append(kServiceWorkerDirectory);
+  if (!user_data_directory.empty())
+    path_ = user_data_directory.Append(kServiceWorkerDirectory);

[kinuko, 2013/11/07 03:02:59]

I know this is coming from existing code, but one question: does this line mean
we may have a conditional like if (path_.empty()) { ... } in the code body?  I
feel just initializing path_ without checking empty() is fine (or even
preferable).

[michaeln, 2013/11/07 23:24:53]

We will be testing if (path_.empty()), that determines whether things get
written to disk or not.

[kinuko, 2013/11/08 02:08:02]

Ok... I generally prefer explicit flag for behavior control (having implicit
behavior makes things harder), but if we want to take it easy can we explicitly
document it in the header?

 }
 
-ServiceWorkerContext::~ServiceWorkerContext() {}
+ServiceWorkerContextCore::~ServiceWorkerContextCore() {
+}
 
 }  // namespace content