Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 610093002: Revert "Tempolarily exclude extensions API that are causing crash on Athena" (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Tempolarily exclude extensions API that are causing crash on Athena" This wasn't enough and was causing compilation error in clean build. This reverts commit 2a244c81663940528ba86dd7515f3ce5e7341e6f. BUG=414340 TBR=yoz@chromium.org, sky@chromium.org Committed: https://crrev.com/2133f1b241ddd95edaf8d7eeedd3d0bc137ee912 Cr-Commit-Position: refs/heads/master@{#297099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -59 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 5 chunks +20 lines, -29 lines 0 comments Download
M chrome/common/extensions/api/schemas.gni View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 5 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
oshima
6 years, 2 months ago (2014-09-27 02:31:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610093002/1
6 years, 2 months ago (2014-09-27 02:32:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 29e57dbd0e353f82963be3bd9c3079d8a191abd5
6 years, 2 months ago (2014-09-27 03:21:33 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 03:22:17 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2133f1b241ddd95edaf8d7eeedd3d0bc137ee912
Cr-Commit-Position: refs/heads/master@{#297099}

Powered by Google App Engine
This is Rietveld 408576698