Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 610083002: Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. R=jamesr@chromium.org Committed: https://crrev.com/a60566701028a7344d17826076780eeb84b63052 Cr-Commit-Position: refs/heads/master@{#297095}

Patch Set 1 #

Patch Set 2 : missed a few #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M mojo/embedder/simple_platform_shared_buffer_posix.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_win.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/embedder/test_embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/core_test_base.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/system/raw_channel_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/raw_channel_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
viettrungluu
6 years, 2 months ago (2014-09-27 01:13:12 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-09-27 01:25:36 UTC) #2
jamesr
lgtm
6 years, 2 months ago (2014-09-27 01:25:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610083002/20001
6 years, 2 months ago (2014-09-27 01:28:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8bf0d80b4becce37aa5564ae1d18e1c393d85032
6 years, 2 months ago (2014-09-27 02:19:40 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a60566701028a7344d17826076780eeb84b63052 Cr-Commit-Position: refs/heads/master@{#297095}
6 years, 2 months ago (2014-09-27 02:20:31 UTC) #7
dcheng
6 years, 2 months ago (2014-09-27 07:42:19 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/609033002/ by dcheng@chromium.org.

The reason for reverting is: scoped_ptr nullptr support was reverted..

Powered by Google App Engine
This is Rietveld 408576698