Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: chrome/browser/ssl/chrome_ssl_host_state_delegate.h

Issue 610063002: Fix UMA stat for expiration of certificate memory decisions (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fixed comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/chrome_ssl_host_state_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/chrome_ssl_host_state_delegate.h
diff --git a/chrome/browser/ssl/chrome_ssl_host_state_delegate.h b/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
index da95d89f231691027a78d84347fdd472c8ade502..4855204cb47a496d22168a7fcc0a9d48b51971ae 100644
--- a/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
+++ b/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
@@ -117,6 +117,29 @@ class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
// same-origin frames in one processs but cannot jump between processes.
std::set<BrokenHostEntry> ran_insecure_content_hosts_;
+ // This is a GUID to mark this unique session. Whenever a certificate decision
+ // expiration is set, the GUID is saved as well so Chrome can tell if it was
+ // last set during the current session. This is used by the
+ // FORGET_SSL_EXCEPTION_DECISIONS_AT_SESSION_END experimental group to
+ // determine if the expired_previous_decision bit should be set on queries.
+ //
+ // Why not just iterate over the set of current extensions and mark them all
+ // as expired when the session starts, rather than storing a GUID for the
+ // current session? Glad you asked! Unfortunately, content settings does not
+ // currently support iterating over all current *compound* content setting
+ // values (iteration only works for simple content settings). While this could
+ // be added, it would be a fair amount of work for what amounts to a temporary
+ // measurement problem, so it's not worth the complexity.
+ //
+ // TODO(jww): This is only used by the default and disable groups of the
+ // certificate memory decisions experiment to tell if a decision has expired
+ // since the last session. Since this is only used for UMA purposes, this
+ // should be removed after the experiment has finished, and a call to Clear()
+ // should be added to the constructor and destructor for members of the
+ // FORGET_SSL_EXCEPTION_DECISIONS_AT_SESSION_END groups. See
+ // https://crbug.com/418631 for more details.
+ const std::string current_expiration_guid_;
+
DISALLOW_COPY_AND_ASSIGN(ChromeSSLHostStateDelegate);
};
« no previous file with comments | « no previous file | chrome/browser/ssl/chrome_ssl_host_state_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698