Issue 61003004: Delete ibus_object and move ibus_text to chromeos/ime.

Issue 61003004: Delete ibus_object and move ibus_text to chromeos/ime. (Closed)

Created:
7 years, 1 month ago by Hiro Komatsu

Modified:
7 years, 1 month ago

Reviewers:
satorux1, Seigo Nonaka

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Delete ibus_object and move ibus_text to chromeos/ime. This patch focuses on the deletion and relocation keeping the logic as-is. BUG=275262 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235726

Patch Set 1 #

Total comments: 10

Patch Set 2 : Modified based on the review. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -1278 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_ibus_browserttests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/chromeos.gyp	View		4 chunks	+3 lines, -6 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_object.h	View		1 chunk	+0 lines, -241 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_object.cc	View		1 chunk	+0 lines, -316 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_object_unittest.cc	View		1 chunk	+0 lines, -180 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_text.h	View		1 chunk	+0 lines, -190 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_text.cc	View		1 chunk	+0 lines, -239 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_text_unittest.cc	View		1 chunk	+0 lines, -100 lines	0 comments	Download
A	chromeos/ime/ibus_text.h	View	1	1 chunk	+86 lines, -0 lines	0 comments	Download
A	chromeos/ime/ibus_text.cc	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
A	chromeos/ime/ibus_text_unittest.cc	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download
M	chromeos/ime/mock_ime_input_context_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/ime/mock_ime_input_context_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ime/input_method_ibus.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ime/input_method_ibus_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Hiro Komatsu

This patch depends on: * https://codereview.chromium.org/68503002/ * https://codereview.chromium.org/68603002/ * https://codereview.chromium.org/70053003/ Satoru, please review this patch ...

7 years, 1 month ago (2013-11-13 11:37:25 UTC) #1

Seigo Nonaka

lgtm with nits https://codereview.chromium.org/61003004/diff/1/chromeos/ime/ibus_text.cc File chromeos/ime/ibus_text.cc (right): https://codereview.chromium.org/61003004/diff/1/chromeos/ime/ibus_text.cc#newcode8 chromeos/ime/ibus_text.cc:8: #include "base/values.h" These includes are no ...

7 years, 1 month ago (2013-11-13 14:09:52 UTC) #2

Hiro Komatsu

https://codereview.chromium.org/61003004/diff/1/chromeos/ime/ibus_text.cc File chromeos/ime/ibus_text.cc (right): https://codereview.chromium.org/61003004/diff/1/chromeos/ime/ibus_text.cc#newcode8 chromeos/ime/ibus_text.cc:8: #include "base/values.h" On 2013/11/13 14:09:52, Seigo Nonaka wrote: > ...

7 years, 1 month ago (2013-11-14 02:55:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/61003004/90001

7 years, 1 month ago (2013-11-18 07:49:58 UTC) #5

Message was sent while issue was closed.

Change committed as 235726

Expand Messages | Collapse Messages