Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 61003002: Fix bug preventing app icons in notification settings view. (Closed)

Created:
7 years, 1 month ago by dewittj
Modified:
7 years, 1 month ago
Reviewers:
jianli
CC:
chromium-reviews
Visibility:
Public.

Description

Fix bug preventing app icons in notification settings view. Icons loaded asynchronously needed to cause a relayout instead of just a change to the layout manager. R=jianli@chromium.org BUG=315244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/message_center/views/notifier_settings_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dewittj
7 years, 1 month ago (2013-11-05 21:44:08 UTC) #1
dewittj
also, since I'm not really sure, should I also call SchedulePaint?
7 years, 1 month ago (2013-11-05 21:49:45 UTC) #2
jianli
lgtm
7 years, 1 month ago (2013-11-05 21:55:19 UTC) #3
jianli
I think it is not needed since GridLayout::Layout will update the bounds of each subview ...
7 years, 1 month ago (2013-11-05 21:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/61003002/1
7 years, 1 month ago (2013-11-05 22:22:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94289
7 years, 1 month ago (2013-11-06 02:38:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/61003002/1
7 years, 1 month ago (2013-11-06 18:01:59 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 07:43:14 UTC) #8
Message was sent while issue was closed.
Change committed as 233532

Powered by Google App Engine
This is Rietveld 408576698