Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 610003002: Override SkCanvas::drawImage() in SkRecorder. (Closed)

Created:
6 years, 2 months ago by Rémi Piotaix
Modified:
6 years, 2 months ago
CC:
reviews_skia.org, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Override SkCanvas::drawImage() in SkRecorder. BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/65151754b9fdb6a968d7307764c20655d1b680a0

Patch Set 1 #

Patch Set 2 : Add tests #

Total comments: 22

Patch Set 3 : Corrections according to comments #

Patch Set 4 : Extracted changes to tests/CanvasTest.cpp in an other CL #

Total comments: 6

Patch Set 5 : Corrections according to comments #

Patch Set 6 : Rebase master #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -4 lines) Patch
M src/core/SkRecordDraw.cpp View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M src/core/SkRecords.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/image/SkImagePriv.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Raster.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 2 3 4 5 2 chunks +56 lines, -0 lines 1 comment Download
M tests/RecordReplaceDrawTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M tests/RecorderTest.cpp View 1 2 3 4 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (3 generated)
Rémi Piotaix
PTAL
6 years, 2 months ago (2014-09-26 21:29:29 UTC) #2
reed1
adding the picture experts
6 years, 2 months ago (2014-09-26 21:32:25 UTC) #4
reed1
how much more to update other SkCanvas subclasses? (Pipe, Deferred, NWay, etc.)?
6 years, 2 months ago (2014-09-26 21:33:05 UTC) #5
Rémi Piotaix
On 2014/09/26 21:33:05, reed1 wrote: > how much more to update other SkCanvas subclasses? (Pipe, ...
6 years, 2 months ago (2014-09-26 21:50:07 UTC) #6
mtklein
The thrust of the new code looks good to me. I have a few requests ...
6 years, 2 months ago (2014-09-27 15:41:22 UTC) #7
robertphillips
https://codereview.chromium.org/610003002/diff/20001/src/image/SkImagePriv.h File src/image/SkImagePriv.h (right): https://codereview.chromium.org/610003002/diff/20001/src/image/SkImagePriv.h#newcode35 src/image/SkImagePriv.h:35: // in which case the surface may need to ...
6 years, 2 months ago (2014-09-29 17:07:56 UTC) #8
Rémi Piotaix
https://codereview.chromium.org/610003002/diff/20001/src/core/SkRecordDraw.cpp File src/core/SkRecordDraw.cpp (right): https://codereview.chromium.org/610003002/diff/20001/src/core/SkRecordDraw.cpp#newcode346 src/core/SkRecordDraw.cpp:346: return this->adjustAndMap(SkRect::MakeXYWH(op.left, op.top, image->width(), image->height()), On 2014/09/27 15:41:22, mtklein ...
6 years, 2 months ago (2014-09-29 17:57:55 UTC) #9
reed1
https://codereview.chromium.org/610003002/diff/20001/tests/RecordDrawTest.cpp File tests/RecordDrawTest.cpp (right): https://codereview.chromium.org/610003002/diff/20001/tests/RecordDrawTest.cpp#newcode305 tests/RecordDrawTest.cpp:305: SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterPMColor(10, 10)); 1. Can we using an outer-loop ...
6 years, 2 months ago (2014-09-29 18:08:26 UTC) #10
Rémi Piotaix
https://codereview.chromium.org/610003002/diff/20001/tests/RecordDrawTest.cpp File tests/RecordDrawTest.cpp (right): https://codereview.chromium.org/610003002/diff/20001/tests/RecordDrawTest.cpp#newcode305 tests/RecordDrawTest.cpp:305: SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterPMColor(10, 10)); On 2014/09/29 18:08:26, reed1 wrote: > ...
6 years, 2 months ago (2014-09-29 18:40:21 UTC) #11
mtklein
Except for a few nits, this LGTM. Please let other folks review to their satisfaction ...
6 years, 2 months ago (2014-09-30 14:42:21 UTC) #12
reed1
lgtm
6 years, 2 months ago (2014-09-30 15:43:07 UTC) #13
Rémi Piotaix
https://codereview.chromium.org/610003002/diff/60001/tests/RecordDrawTest.cpp File tests/RecordDrawTest.cpp (right): https://codereview.chromium.org/610003002/diff/60001/tests/RecordDrawTest.cpp#newcode265 tests/RecordDrawTest.cpp:265: const SkPaint* paint = NULL) SK_OVERRIDE { On 2014/09/30 ...
6 years, 2 months ago (2014-09-30 15:48:10 UTC) #14
robertphillips
lgtm
6 years, 2 months ago (2014-09-30 16:10:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610003002/100001
6 years, 2 months ago (2014-10-16 18:51:26 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 65151754b9fdb6a968d7307764c20655d1b680a0
6 years, 2 months ago (2014-10-16 18:58:48 UTC) #18
tfarina
6 years, 2 months ago (2014-10-24 00:52:15 UTC) #19
Message was sent while issue was closed.
https://codereview.chromium.org/610003002/diff/100001/tests/RecordDrawTest.cpp
File tests/RecordDrawTest.cpp (right):

https://codereview.chromium.org/610003002/diff/100001/tests/RecordDrawTest.cp...
tests/RecordDrawTest.cpp:284: typedef SkCanvas INHERITED;
Filed https://code.google.com/p/skia/issues/detail?id=3059 for this.

Powered by Google App Engine
This is Rietveld 408576698