Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 609963004: Move explicit conversion operators to the banned section. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
awong, chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move explicit conversion operators to the banned section. Unfortunately, they are broken as implemented in MSVS 2013. Committed: https://crrev.com/0e418df26c45af6a62d2c3e7b05f4496058d5e86 Cr-Commit-Position: refs/heads/master@{#297066}

Patch Set 1 #

Patch Set 2 : Rebase on top of avi's patch #

Patch Set 3 : Really rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M styleguide/c++/c++11.html View 1 2 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
dcheng
I'm not sure why there's two banned sections in the disallow (rvalue references and everything ...
6 years, 2 months ago (2014-09-26 21:31:33 UTC) #2
jamesr
Avi has a patch in the CQ to consolidate the banned bits, can you rebase ...
6 years, 2 months ago (2014-09-26 21:32:21 UTC) #3
Avi (use Gerrit)
On 2014/09/26 21:32:21, jamesr wrote: > Avi has a patch in the CQ to consolidate ...
6 years, 2 months ago (2014-09-26 21:32:54 UTC) #4
dcheng
Rebased on top of avi's patch.
6 years, 2 months ago (2014-09-26 21:37:21 UTC) #5
Avi (use Gerrit)
On 2014/09/26 21:37:21, dcheng wrote: > Rebased on top of avi's patch. FYI my patch ...
6 years, 2 months ago (2014-09-26 22:15:17 UTC) #6
jamesr
lgtm
6 years, 2 months ago (2014-09-26 22:42:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609963004/40001
6 years, 2 months ago (2014-09-26 22:44:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 6580605bb2a988bf637ce982e68185859f73a20b
6 years, 2 months ago (2014-09-26 23:25:18 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 23:25:48 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e418df26c45af6a62d2c3e7b05f4496058d5e86
Cr-Commit-Position: refs/heads/master@{#297066}

Powered by Google App Engine
This is Rietveld 408576698