Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/base/ui_base_tests.gyp

Issue 609963003: Fix ui_unittests clobber issue on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TODO fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ui_base_tests.gyp
diff --git a/ui/base/ui_base_tests.gyp b/ui/base/ui_base_tests.gyp
index 9a77555423eff8dad9cddf9768ef9931c5314adf..2deda706c5af0e070a0e33ddacdfdb63961957d1 100644
--- a/ui/base/ui_base_tests.gyp
+++ b/ui/base/ui_base_tests.gyp
@@ -56,6 +56,12 @@
'target_name': 'ui_unittests_apk',
'type': 'none',
'dependencies': [
+ # TODO(tfarina): This is a layer violation and should be removed.
+ # crbug.com/176960
+ # For now this is here as a temporary band-aid to fix the clobber
+ # issue we are seeing when running this target on Android.
+ # crbug.com/374490
+ '../../chrome/chrome_resources.gyp:packed_resources',
'ui_unittests',
],
'variables': {
@@ -67,6 +73,12 @@
'target_name': 'ui_base_unittests_apk',
'type': 'none',
'dependencies': [
+ # TODO(tfarina): This is a layer violation and should be removed.
+ # crbug.com/176960
+ # For now this is here as a temporary band-aid to fix the clobber
+ # issue we are seeing when running this target on Android.
+ # crbug.com/374490
+ '../../chrome/chrome_resources.gyp:packed_resources',
'ui_base_unittests',
],
'variables': {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698