Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 609963003: Fix ui_unittests clobber issue on Android. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cjhopman, tony
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix ui_unittests clobber issue on Android. Nobody knows yet what the right fix should be. So this is just a band-aid, until we figure it out. It isn't bad as it may look like, but certainly far from the ideal as nothing from ui/ should be depending on things declared in chrome/. BUG=374490 TEST=git cl try -c -r HEAD passes on Android. R=sky@chromium.org,primiano@chromium.org Committed: https://crrev.com/442f3002976bdfc2793ec906cafcdfb58ff80c6f Cr-Commit-Position: refs/heads/master@{#297085}

Patch Set 1 #

Patch Set 2 : TODO fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ui/base/ui_base_tests.gyp View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
green trybots. \o/ PTAL.
6 years, 2 months ago (2014-09-26 21:12:51 UTC) #1
sky
LGTM
6 years, 2 months ago (2014-09-26 22:31:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609963003/20001
6 years, 2 months ago (2014-09-27 00:35:32 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 127229c135d37a9ea1e3ba879fc32be7b820eace
6 years, 2 months ago (2014-09-27 00:40:05 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 00:40:40 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/442f3002976bdfc2793ec906cafcdfb58ff80c6f
Cr-Commit-Position: refs/heads/master@{#297085}

Powered by Google App Engine
This is Rietveld 408576698