content/browser/frame_host/render_frame_host_impl.cc - Issue 609943002: Ensure that the browser’s copy of page id is in sync with the renderer’s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 609943002: Ensure that the browser’s copy of page id is in sync with the renderer’s. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/crash_keys.cc ('k') | content/browser/renderer_host/render_view_host_delegate.h » ('j') | content/browser/renderer_host/render_view_host_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 585fb225282f1448ba825bd80d6f1509fe1bc9d8..a614c7ec79e2391987b3269e678c7022f63dae66 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1002,6 +1002,7 @@ void RenderFrameHostImpl::OnUpdateTitle(

int32 page_id,

const base::string16& title,

blink::WebTextDirection title_direction) {

+ CHECK_EQ(render_view_host_->page_id_, page_id);

Charlie Reis 2014/09/26 19:30:11 This is the one we haven't seen crash, right? Hop

Avi (use Gerrit) 2014/09/26 19:58:18 Yep, exactly. I'm tired of instrumenting it up whe

// This message is only sent for top-level frames. TODO(avi): when frame tree

// mirroring works correctly, add a check here to enforce it.

if (title.length() > kMaxTitleChars) {