Add ability for Function to generate source

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 5425 matching lines @@
     } else {
       tmp = cls.UserVisibleName();
     }
   }
   tmp = String::Concat(tmp, Symbols::Dot());
   const String& suffix = String::Handle(UserVisibleName());
   return String::Concat(tmp, suffix);
 }
 
 
+RawString* Function::GenerateSource() {

[hausner, 2013/11/05 22:30:05]

I suggest making this a bit more smart. If we do have the source code for the
function, we should return the original source code, not synthesized sources.
Maybe add a function to class Script that returns either the actual source code
between two tokens (rounded to beginning and end of line possibly) or generated
source code if there is no source code available.

+  const Script& func_script = Script::Handle(script());
+  const TokenStream& token_stream = TokenStream::Handle(func_script.tokens());
+  return token_stream.GenerateSource(token_pos(), end_token_pos());
+}
+
+
 // Construct fingerprint from token stream. The token stream contains also
 // arguments.
 int32_t Function::SourceFingerprint() const {
   uint32_t result = String::Handle(Signature()).Hash();
   TokenStream::Iterator tokens_iterator(TokenStream::Handle(
       Script::Handle(script()).tokens()), token_pos());
   Object& obj = Object::Handle();
   String& literal = String::Handle();
   while (tokens_iterator.CurrentPosition() < end_token_pos()) {
     uint32_t val = 0;
@@ skipping 787 matching lines @@
 RawString* TokenStream::PrivateKey() const {
   return raw_ptr()->private_key_;
 }
 
 
 void TokenStream::SetPrivateKey(const String& value) const {
   StorePointer(&raw_ptr()->private_key_, value.raw());
 }
 
 
-RawString* TokenStream::GenerateSource() const {
-  Iterator iterator(*this, 0, Iterator::kAllTokens);
+RawString* TokenStream::GenerateSource(intptr_t start_tok_pos,
+                                       intptr_t end_tok_pos) const {
+  Iterator iterator(*this, start_tok_pos, Iterator::kAllTokens);
   const ExternalTypedData& data = ExternalTypedData::Handle(GetStream());
   const GrowableObjectArray& literals =
       GrowableObjectArray::Handle(GrowableObjectArray::New(data.Length()));
   const String& private_key = String::Handle(PrivateKey());
   intptr_t private_len = private_key.Length();
 
   Token::Kind curr = iterator.CurrentTokenKind();
   Token::Kind prev = Token::kILLEGAL;
   // Handles used in the loop.
   Object& obj = Object::Handle();
   String& literal = String::Handle();
   // Current indentation level.
   int indent = 0;
 
   while (curr != Token::kEOS) {
+    if ((end_tok_pos > 0) && (iterator.CurrentPosition() > end_tok_pos)) {

[hausner, 2013/11/05 22:30:05]

Is end_token_pos inclusive or exclusive? Typically we use exclusive end
positions. In that case, the comparison should be >=. In any case, maybe a
comment in the header file would be good to clarify. 

+      // We've reached the end of the token stream we want.
+      break;
+    }
     // Remember current values for this token.
     obj = iterator.CurrentToken();
     literal = iterator.MakeLiteralToken(obj);
     // Advance to be able to use next token kind.
     iterator.Advance();
     Token::Kind next = iterator.CurrentTokenKind();
 
     // Handle the current token.
     if (curr == Token::kSTRING) {
       bool escape_characters = false;
@@ skipping 9464 matching lines @@
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   JSONObject jsobj(stream);
 }
 
 
 }  // namespace dart