remoting/codec/audio_decoder_verbatim.cc - Issue 609923004: Cleanup usage of scoped_ptr<> in remoting for C++11

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/codec/audio_decoder_verbatim.cc

Issue 609923004: Cleanup usage of scoped_ptr<> in remoting for C++11 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/codec/audio_decoder_verbatim.cc

diff --git a/remoting/codec/audio_decoder_verbatim.cc b/remoting/codec/audio_decoder_verbatim.cc

index 6c9b6394c18adb2d937b6fa1425452a8a1c728fc..a04e2a5737ef3c5510a82f9f30242bda13ed9cb6 100644

--- a/remoting/codec/audio_decoder_verbatim.cc

+++ b/remoting/codec/audio_decoder_verbatim.cc

@@ -26,7 +26,7 @@ scoped_ptr<AudioPacket> AudioDecoderVerbatim::Decode(

(packet->data(0).size() %

(AudioPacket::CHANNELS_STEREO * AudioPacket::BYTES_PER_SAMPLE_2) != 0)) {

LOG(WARNING) << "Verbatim decoder received an invalid packet.";

- return scoped_ptr<AudioPacket>();

+ return nullptr;

}

return packet.Pass();

}