Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 609923003: Adding blink side flag that allows disabling YUV decoding (Closed)

Created:
6 years, 2 months ago by sugoi1
Modified:
6 years, 2 months ago
CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adding blink side flag that allows disabling YUV decoding BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182798

Patch Set 1 #

Total comments: 1

Patch Set 2 : New name #

Total comments: 1

Patch Set 3 : Removed unused variable #

Patch Set 4 : Added base class change #

Patch Set 5 : Moved from WebSettings to WebRuntimeFeatures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/DecodingImageGenerator.cpp View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
sugoi1
6 years, 2 months ago (2014-09-26 19:12:03 UTC) #2
Stephen White
https://codereview.chromium.org/609923003/diff/1/Source/platform/graphics/DecodingImageGenerator.h File Source/platform/graphics/DecodingImageGenerator.h (right): https://codereview.chromium.org/609923003/diff/1/Source/platform/graphics/DecodingImageGenerator.h#newcode52 Source/platform/graphics/DecodingImageGenerator.h:52: static void setYUVDecodingEnabled(bool); Since this doesn't really decode YUV ...
6 years, 2 months ago (2014-09-26 19:21:14 UTC) #4
Stephen White
https://codereview.chromium.org/609923003/diff/20001/Source/web/WebSettingsImpl.cpp File Source/web/WebSettingsImpl.cpp (right): https://codereview.chromium.org/609923003/diff/20001/Source/web/WebSettingsImpl.cpp#newcode515 Source/web/WebSettingsImpl.cpp:515: m_decodeToYUVEnabled = enabled; Don't think there's any need for ...
6 years, 2 months ago (2014-09-26 19:31:00 UTC) #5
Stephen White
LGTM
6 years, 2 months ago (2014-09-26 19:34:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609923003/40001
6 years, 2 months ago (2014-09-26 19:35:51 UTC) #8
sugoi1
Adding jamesr@ as reviewer to get approval from an owner.
6 years, 2 months ago (2014-09-26 19:50:16 UTC) #11
jamesr
This isn't a WebSetting since it is not specific to a particular context, it's global ...
6 years, 2 months ago (2014-09-26 20:17:16 UTC) #12
sugoi1
On 2014/09/26 20:17:16, jamesr wrote: > This isn't a WebSetting since it is not specific ...
6 years, 2 months ago (2014-09-26 20:27:23 UTC) #13
sugoi1
On 2014/09/26 20:27:23, sugoi1 wrote: > On 2014/09/26 20:17:16, jamesr wrote: > > This isn't ...
6 years, 2 months ago (2014-09-26 20:52:42 UTC) #14
jamesr
lgtm
6 years, 2 months ago (2014-09-26 20:53:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609923003/80001
6 years, 2 months ago (2014-09-26 20:57:42 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 22:50:33 UTC) #18
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 182798

Powered by Google App Engine
This is Rietveld 408576698