Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 609903002: Fix WebviewBackendSettings use of adb (Closed)

Created:
6 years, 2 months ago by hjd
Modified:
6 years, 2 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WebviewBackendSettings use of adb adb was moved to being owned by AndroidBrowserBackend in crrev.com/522553002/. Committed: https://crrev.com/3f632e1b64c739816497604409bad28eeed8dc5f Cr-Commit-Position: refs/heads/master@{#297000}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix pylint better. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 9 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hjd
ptal
6 years, 2 months ago (2014-09-26 17:30:28 UTC) #2
nednguyen
Lgtm. If pylint complain about unused adb param, you can change it to _adb https://codereview.chromium.org/609903002/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ...
6 years, 2 months ago (2014-09-26 17:40:02 UTC) #3
hjd
https://codereview.chromium.org/609903002/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py (right): https://codereview.chromium.org/609903002/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py#newcode50 tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:50: def PushProfile(self, _, _): On 2014/09/26 17:40:02, nednguyen wrote: ...
6 years, 2 months ago (2014-09-26 17:45:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609903002/20001
6 years, 2 months ago (2014-09-26 17:47:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ebcdff9a1a20738e65e9eb2da247060ec28fca93
6 years, 2 months ago (2014-09-26 19:21:38 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:22:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f632e1b64c739816497604409bad28eeed8dc5f
Cr-Commit-Position: refs/heads/master@{#297000}

Powered by Google App Engine
This is Rietveld 408576698